-
Notifications
You must be signed in to change notification settings - Fork 382
fix: Download expected bb version if installed backend has version mismatch
#3150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
395289b
chore: warn if backend version mismatch
kobyhallx d8749cc
chore: add smart contract assert
kobyhallx 9ca358d
chore: assert version on ly on barretenberg backends
kobyhallx 54616a1
chore: nits
TomAFrench 4be4041
chore: replace-download correct backend version
kobyhallx b59ee16
Merge branch 'kh-backend-version-check' of github.com:noir-lang/noir …
kobyhallx b11aa42
chore: add handling for case where `bb --version` returns an error
TomAFrench 0818923
fix: add `assert_correct_version` to methods where it was missing
TomAFrench 7574021
Merge branch 'master' into kh-backend-version-check
kobyhallx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| use std::path::Path; | ||
|
|
||
| use crate::BackendError; | ||
|
|
||
| use super::string_from_stderr; | ||
|
|
||
| /// VersionCommand will call the backend binary | ||
| /// to query installed version. | ||
| pub(crate) struct VersionCommand {} | ||
|
|
||
| impl VersionCommand { | ||
| pub(crate) fn run(self, binary_path: &Path) -> Result<String, BackendError> { | ||
| let mut command = std::process::Command::new(binary_path); | ||
|
|
||
| command | ||
| .arg("--version"); | ||
|
|
||
| let output = command.output()?; | ||
| if output.status.success() { | ||
| match String::from_utf8(output.stdout) { | ||
| Ok(result) => Ok(result), | ||
| Err(_) => Err(BackendError::CommandFailed("Unexpected output from --version check.".to_owned())), | ||
| } | ||
| } else { | ||
| Err(BackendError::CommandFailed(string_from_stderr(&output.stderr))) | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.