chore: make acvm a non-optional field on DebugContext#3149
Merged
TomAFrench merged 3 commits intomasterfrom Oct 13, 2023
Merged
chore: make acvm a non-optional field on DebugContext#3149TomAFrench merged 3 commits intomasterfrom
acvm a non-optional field on DebugContext#3149TomAFrench merged 3 commits intomasterfrom
Conversation
TomAFrench
commented
Oct 13, 2023
5 tasks
* master: chore(debugger): avoid taking ownership of Circuit when building debug context (#3147)
kevaundray
approved these changes
Oct 13, 2023
Sakapoi
pushed a commit
to Sakapoi/noir_fork
that referenced
this pull request
Oct 19, 2023
…3149) Co-authored-by: Tom French <git@tomfren.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #2995 (comment)
Summary*
This PR addresses a workaround for the borrow checker in #2995.
replholds two references toContextso we can't move the witness map out of the containedACVMinstance whilerepl(and so the references) exists.As we don't need
replonce we've finished execution, this PR explicitly dropsreplto remove those references, We can then unwrap theRefCelland get at the containedContextto pull out the witness map.cc @mverzilli @ggiraldez as you may be interested in this solution.
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.