Skip to content

chore(ci): replace webdriver with playwright #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevaundray merged 2 commits into from
Oct 4, 2023
Merged

chore(ci): replace webdriver with playwright #2988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49ba9b8
chore(ci): replace webdriver with playwright
TomAFrench Oct 4, 2023
1806379
chore(ci): install playwright for integration tests
TomAFrench Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/test-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,9 @@ jobs:
- name: Install Yarn dependencies
uses: ./.github/actions/setup

- name: Install Playwright
uses: ./.github/actions/install-playwright

- name: Install jq
run: sudo apt-get install jq

Expand Down
2 changes: 1 addition & 1 deletion compiler/integration-tests/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"@nomicfoundation/hardhat-ethers": "^3.0.0",
"@web/dev-server-esbuild": "^0.3.6",
"@web/test-runner": "^0.15.3",
"@web/test-runner-webdriver": "^0.7.0",
"@web/test-runner-playwright": "^0.10.0",
"eslint": "^8.50.0",
"eslint-plugin-prettier": "^5.0.0",
"ethers": "^6.7.1",
Expand Down
14 changes: 4 additions & 10 deletions compiler/integration-tests/web-test-runner.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { defaultReporter } from '@web/test-runner';
import { summaryReporter } from '@web/test-runner';
import { fileURLToPath } from 'url';
import { esbuildPlugin } from '@web/dev-server-esbuild';
import { webdriverLauncher } from '@web/test-runner-webdriver';
import { playwrightLauncher } from "@web/test-runner-playwright";

let reporter = summaryReporter();
const debugPlugins = [];
Expand All @@ -21,15 +21,9 @@ if (process.env.CI !== 'true' || process.env.RUNNER_DEBUG === '1') {

export default {
browsers: [
webdriverLauncher({
automationProtocol: 'webdriver',
capabilities: {
browserName: 'firefox',
'moz:firefoxOptions': {
args: ['-headless'],
},
},
}),
playwrightLauncher({ product: "chromium" }),
// playwrightLauncher({ product: "webkit" }),
// playwrightLauncher({ product: "firefox" }),
],
plugins: [
esbuildPlugin({
Expand Down
1 change: 0 additions & 1 deletion compiler/wasm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
"@web/dev-server-esbuild": "^0.3.6",
"@web/test-runner": "^0.15.3",
"@web/test-runner-playwright": "^0.10.0",
"@web/test-runner-webdriver": "^0.7.0",
"mocha": "^10.2.0"
}
}
1 change: 0 additions & 1 deletion tooling/noirc_abi_wasm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
"@web/dev-server-esbuild": "^0.3.6",
"@web/test-runner": "^0.15.3",
"@web/test-runner-playwright": "^0.10.0",
"@web/test-runner-webdriver": "^0.7.0",
"eslint": "^8.50.0",
"mocha": "^10.2.0"
}
Expand Down
Loading