Conversation
|
Lets split this into two PRs -- the first one will introduce Create a new PR with master and not ignore the build artifacts We then modify noir-starter so that it works in CI with that commit, then work on making noir-starter work with the program API |
tooling/noir_js_types/lib/types.ts
Outdated
| generateProof(decompressedWitness: Uint8Array, optimizeForVerifyInCircuit?: boolean): Promise<Uint8Array>; | ||
|
|
||
| // Generates a child proof. Child Proof will be verified in another Circuit. | ||
| generateChildProof(decompressedWitness: Uint8Array): Promise<Uint8Array>; |
There was a problem hiding this comment.
Did we end up with this naming? I kind of like @Savio-Sou suggestion of "intermediate proof" and "final proof" as it sound more descriptive
There was a problem hiding this comment.
Does that make sense in case where you are not doing recursion?
There was a problem hiding this comment.
Does that make sense in case where you are not doing recursion?
The user would stick with generateFinalProof then. Not the cleanest but not the most unintuitive (while more intuitive than generateProof for recursion users, which could be a big group of devs as recursion would be needed for any fairly complex programs running in browsers.)
- `e2e.test.cjs` will now function as demostration of cjs version api
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @aztec/bb.js@0.7.2 |
|
Resolves #2835? |
The user would stick with What's the cleanest? So when creating regular proof what's the meaning of For purpose of easier imagination should we adopt reference to something, like processing a tree? where there might be
|
For non-recursion devs, nothing beats just To get the best of both worlds, we could have |
Description
Problem*
Resolves
Summary*
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.