feat: introduce codegen-verifier section to Nargo.toml by longfin · Pull Request #1138 · noir-lang/noir

longfin · 2023-04-11T19:41:03Z

Related issue(s)

Resolves #1009

Description

Summary of changes

Added codegen-verifier section to Nargo.toml, to enable to config the output directory for nargo codegen-verifier command.

Dependency additions / changes

N/A (maybe 😅 )

Test additions / changes

Checklist

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt with default settings.
I have linked this PR to the issue(s) that it resolves.
I have reviewed the changes on GitHub, line by line.
I have ensured all changes are covered in the description.

Documentation needs

This PR requires documentation updates when merged.

Additional context

kevaundray · 2023-04-12T12:51:01Z

Hi,

Thank you for contributing to the Noir repository :)

The issue which you are aiming to solve has additional context here given by @TomAFrench here. Its a bit more than just a folder rename!

longfin · 2023-04-12T14:39:52Z

Hi,

Thank you for contributing to the Noir repository :)

The issue which you are aiming to solve has additional context here given by @TomAFrench here. Its a bit more than just a folder rename!

Thanks for letting me know! I misread that the configurable folder name might be a different PR. 😅 I'll be back after implementation.

crates/nargo_cli/src/cli/codegen_verifier_cmd.rs

longfin · 2023-04-12T17:01:37Z

@kevaundray @TomAFrench PTAL 😄

TomAFrench

Thanks for your help with this issue @longfin

The PR's looking pretty good, I've made a couple of small notes.

crates/nargo/src/manifest/mod.rs

crates/nargo_cli/src/cli/codegen_verifier_cmd.rs

longfin · 2023-04-13T14:32:28Z

@TomAFrench Thanks a lot for the detailed review! I guess that most of them are addressed on 31577ac.

Please take a look and feel free to let me know about remaining or other comments. 😄

longfin · 2023-04-14T14:42:32Z

I'll be back after fixing it 😓

TomAFrench

Thanks @longfin, it's looking really good now. I'm going to merge this soon but I need to add an issue for the feature I mentioned so we can link to that.

crates/nargo_cli/src/cli/codegen_verifier_cmd.rs

TomAFrench · 2023-04-17T12:34:39Z

crates/nargo_cli/src/cli/codegen_verifier_cmd.rs

+/// TODO: Move this function to `PackageManifest` after tracking the root directory.
+/// See also: https://github.com/noir-lang/noir/pull/1138#discussion_r1165351237


I'll make a quick issue detailing this and then we can update this to point at that issue.

kevaundray · 2023-04-24T23:32:56Z

@TomAFrench barring conflicts, can we merge this?

longfin · 2023-04-27T10:01:55Z

@TomAFrench barring conflicts, can we merge this?

I'll take a look today. 💪

longfin · 2023-04-27T10:06:11Z

@kevaundray @TomAFrench In general cases, I prefer to rebase instead of merging since I don't want to leave a merge commit unnecessarily. but my branch already has been exposed and is containing @TomAFrench's commits.

In this case, is there any existing way that the team prefers between merge or rebase?

TomAFrench · 2023-04-27T10:48:28Z

Hey, sorry for the delay on this PR.

@longfin A merge commit into this branch is fine as we'll be squashing all the commits when we merge into master. Rebasing causes some issues when it comes to reviewing (we need to check the entire PR again rather than just the new commit) so we try not to do them once others have started looking at the PR.

longfin · 2023-04-27T15:37:34Z

Conflicts resolved.

@TomAFrench is there a new issue for this comment?

longfin · 2023-04-28T07:23:41Z

Oops, some tests seem to fail. I'll check again.

This PR removes the `nargo codegen-verifier` command and replaces it with an example bash script showing how to use `nargo` in conjunction with `bb` to generate a smart contract verifier. cc @AztecProtocol/devrel Closes noir-lang/noir#4447 Closes noir-lang/noir#1138 Closes noir-lang/noir#2222 Closes noir-lang/noir#1159 Closes noir-lang/noir#1009 Closes noir-lang/noir#3837 Closes noir-lang/noir#2667 --------- Co-authored-by: ludamad <adam.domurad@gmail.com> Co-authored-by: Maxim Vezenov <mvezenov@gmail.com>

longfin changed the title ~~Adjust directory name for nargo codegen-verifier~~ feat: Adjust directory name for nargo codegen-verifier Apr 11, 2023

github-actions bot added the doc needed label Apr 11, 2023

longfin marked this pull request as ready for review April 11, 2023 19:57

github-actions bot removed the doc needed label Apr 11, 2023

longfin marked this pull request as draft April 12, 2023 14:40

longfin force-pushed the feature/1009 branch from 8975c64 to 77f482b Compare April 12, 2023 16:49

longfin changed the title ~~feat: Adjust directory name for nargo codegen-verifier~~ feat: Introduce codegen-verifier section to Nargo.toml Apr 12, 2023

github-actions bot added the doc needed label Apr 12, 2023

longfin commented Apr 12, 2023

View reviewed changes

crates/nargo_cli/src/cli/codegen_verifier_cmd.rs Outdated Show resolved Hide resolved

longfin marked this pull request as ready for review April 12, 2023 17:00

TomAFrench reviewed Apr 12, 2023

View reviewed changes

TomAFrench changed the title ~~feat: Introduce codegen-verifier section to Nargo.toml~~ feat: introduce codegen-verifier section to Nargo.toml Apr 12, 2023

longfin marked this pull request as draft April 13, 2023 06:58

longfin force-pushed the feature/1009 branch 2 times, most recently from c5ecd2d to 31577ac Compare April 13, 2023 14:26

longfin requested a review from TomAFrench April 13, 2023 14:32

longfin marked this pull request as ready for review April 13, 2023 14:32

longfin force-pushed the feature/1009 branch from 31577ac to b127e67 Compare April 14, 2023 14:48

TomAFrench reviewed Apr 17, 2023

View reviewed changes

longfin marked this pull request as draft April 27, 2023 10:02

feat: Introduce codegen-verifier section to Nargo.toml (noir-lang#1009)

646f90d

Update crates/nargo_cli/src/cli/codegen_verifier_cmd.rs

e91d1af

longfin force-pushed the feature/1009 branch from 6dbd9b9 to e91d1af Compare April 27, 2023 15:35

longfin requested a review from TomAFrench April 27, 2023 15:38

longfin marked this pull request as ready for review April 27, 2023 15:38

longfin marked this pull request as draft April 28, 2023 07:23

signorecello removed the doc needed label Oct 17, 2023

TomAFrench mentioned this pull request May 16, 2024

chore!: remove backend interactions from nargo AztecProtocol/aztec-packages#6320

Merged

TomAFrench closed this in AztecProtocol/aztec-packages#6320 May 17, 2024

		/// TODO: Move this function to `PackageManifest` after tracking the root directory.
		/// See also: https://github.com/noir-lang/noir/pull/1138#discussion_r1165351237

Conversation

longfin commented Apr 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related issue(s)

Description

Summary of changes

Dependency additions / changes

Test additions / changes

Checklist

Documentation needs

Additional context

Uh oh!

kevaundray commented Apr 12, 2023

Uh oh!

longfin commented Apr 12, 2023

Uh oh!

Uh oh!

longfin commented Apr 12, 2023

Uh oh!

TomAFrench left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

longfin commented Apr 13, 2023

Uh oh!

longfin commented Apr 14, 2023

Uh oh!

TomAFrench left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TomAFrench Apr 17, 2023

Choose a reason for hiding this comment

Uh oh!

kevaundray commented Apr 24, 2023

Uh oh!

longfin commented Apr 27, 2023

Uh oh!

longfin commented Apr 27, 2023

Uh oh!

TomAFrench commented Apr 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

longfin commented Apr 27, 2023

Uh oh!

longfin commented Apr 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

longfin commented Apr 11, 2023 •

edited

Loading

TomAFrench commented Apr 27, 2023 •

edited

Loading