chore(serialisation): Stop generating bincode serde code for C++#10928
chore(serialisation): Stop generating bincode serde code for C++#10928TomAFrench merged 30 commits intomasterfrom
bincode serde code for C++#10928Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Opcode count'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.
| Benchmark suite | Current: a702251 | Previous: 0d6984c | Ratio |
|---|---|---|---|
rollup-tx-merge |
1478 opcodes |
1302 opcodes |
1.14 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
aakoshh
force-pushed
the
af/cpp-no-bincode
branch
from
a702251 to
f2116d5
Compare
|
This is done in aztec-packages using a Python script in AztecProtocol/aztec-packages#19047 Once that is merged, we can safely assume that we can also stop doing it on our side. Until then it's probably safer to keep it in tact, in case we do some serialisation changes and that PR does not get merged, we don't want to accidentally remove bincode support. |
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'ACVM Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: f2116d5 | Previous: e2cdc0b | Ratio |
|---|---|---|---|
perfectly_parallel_batch_inversion_opcodes |
2791080 ns/iter (± 13681) |
2263894 ns/iter (± 72606) |
1.23 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 924bac6 | Previous: 7963300 | Ratio |
|---|---|---|---|
rollup-root |
0.005 s |
0.004 s |
1.25 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
2 participants
Description
Problem
@ludamad asked:
Summary
Skips generating
bincodeformat for C++. I left the struct basedmsgpackin place, since it just adds a few lines of code, without any extra dependency, but if we really really wanted to only supportmsgpack-compactin Barretenberg, then the code to modify would be generate_struct.Additional Context
With this change both the
bincodeand thebincode-legacyformats become unreadable for Barretenberg. It would need further changes in in Barretenberg to remove the decode_bincode fallback.User Documentation
Check one:
PR Checklist
cargo fmton default settings.