Skip to content

Conversation

@rreddy2
Copy link
Contributor

@rreddy2 rreddy2 commented Aug 4, 2025

Summary of Change

Adding Audit Log filtering for the actor parameter (including and excluding)

Before Review

  • Unit Tests are Added/Updated and meet at-least 85% coverage criteria for that feature

Before Merge

  • Ran/Functionally Tested in Dev Environment
  • Documentation Is Updated (Where Appropriate)

@rreddy2 rreddy2 changed the title Audit log actor filter Actor-based Filtering for GH AuditLogExtractor Aug 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
nodestream_github
   plugin.py4175%6
   repos.py94397%37, 81, 85
   teams.py34197%63
   users.py26196%33
nodestream_github/client
   githubclient.py2793986%83–86, 91–93, 155–156, 161–162, 255, 273, 316, 333, 399–400, 428–429, 491–492, 512–513, 548–549, 570–571, 583–584, 604–605, 614–616, 643–644, 664–665, 675–677
TOTAL6194593% 

Tests Skipped Failures Errors Time
54 0 💤 0 ❌ 0 🔥 2.526s ⏱️

ccloes
ccloes previously approved these changes Aug 4, 2025
Copy link

@ccloes ccloes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool functionality. Please get @jbristow 's review on this.

@rreddy2 rreddy2 requested a review from jbristow August 6, 2025 19:04
@rreddy2 rreddy2 requested a review from jbristow August 7, 2025 21:13
@rreddy2 rreddy2 force-pushed the audit-log-actor-filter branch from 9a18274 to 0fe2e87 Compare August 8, 2025 17:51
@rreddy2 rreddy2 force-pushed the audit-log-actor-filter branch from de15b26 to 0f9a5d0 Compare August 8, 2025 17:56
@rreddy2 rreddy2 merged commit 2ee2817 into master Aug 8, 2025
4 checks passed
@rreddy2 rreddy2 deleted the audit-log-actor-filter branch August 8, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants