Skip to content

Conversation

@jbristow
Copy link
Contributor

@jbristow jbristow commented Apr 3, 2025

Summary of Change

While queueing a lot of API calls that ran up against the rate limiting functionality, we found a race condition in the limits dependency. Luckily, they'd already fixed the problem so it was able to go out in a quick release. (Many thanks to @alisafee for the responsiveness to our issue even though I still haven't been able to get enough logs to replicate it outside of production either)

Before Review

  • Unit Tests are Added/Updated and meet at-least 85% coverage criteria for that feature

Before Merge

  • Ran/Functionally Tested in Dev Environment
  • Documentation Is Updated (Where Appropriate)

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
nodestream_github
   plugin.py4175%6
   repos.py94397%37, 81, 85
   teams.py34197%63
nodestream_github/client
   githubclient.py2443088%93–94, 99–100, 193, 211, 247, 264, 330–331, 358–359, 420–421, 441–442, 477–478, 499–500, 512–513, 533–534, 543–544, 571–572, 592–593
TOTAL5733594% 

Tests Skipped Failures Errors Time
35 0 💤 0 ❌ 0 🔥 1.777s ⏱️

@jbristow jbristow merged commit 75bf7dd into master Apr 3, 2025
4 checks passed
@jbristow jbristow deleted the upgrade-limits branch April 3, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants