Skip to content

Conversation

@jbristow
Copy link
Contributor

Summary of Change

The end user may want to disable some API calls that are too noisy or irrelevant for their use case.

Before Review

  • Unit Tests are Added/Updated and meet at-least 85% coverage criteria for that feature

Before Merge

  • Ran/Functionally Tested in Dev Environment
  • Documentation Is Updated (Where Appropriate)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
nodestream_github
   plugin.py4175%6
   repos.py94397%37, 81, 85
   teams.py34197%63
nodestream_github/client
   githubclient.py2443088%93–94, 99–100, 193, 211, 247, 264, 330–331, 358–359, 420–421, 441–442, 477–478, 499–500, 512–513, 533–534, 543–544, 571–572, 592–593
TOTAL5733594% 

Tests Skipped Failures Errors Time
35 0 💤 0 ❌ 0 🔥 1.712s ⏱️

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this init file intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this was picked up by a new ruff rule they finished implementing recently: https://docs.astral.sh/ruff/rules/implicit-namespace-package/#why-is-this-bad

@jbristow jbristow merged commit 23e8626 into master Mar 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants