Skip to content

Conversation

@rreddy2
Copy link
Contributor

@rreddy2 rreddy2 commented Mar 18, 2025

Summary of Change

Adding an Audit Log Extractor for the GitHub plugin. I was able to test this locally and it seems to work as expected! As of now, we will support filtering the audit log based on different action(s). There may be some room to add more filtering based on time as well, but at the moment I don't think it'll be required.

Before Review

  • Unit Tests are Added/Updated and meet at-least 85% coverage criteria for that feature

Before Merge

  • Ran/Functionally Tested in Dev Environment
  • Documentation Is Updated (Where Appropriate)

@rreddy2 rreddy2 closed this Mar 18, 2025
@rreddy2 rreddy2 reopened this Mar 18, 2025
Copy link
Contributor

@jbristow jbristow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a merge, ping me when you need a refreshed approval

@github-actions
Copy link
Contributor

Coverage

Coverage Report
FileStmtsMissCoverMissing
nodestream_github
   plugin.py4175%6
   repos.py80396%30, 70, 74
   teams.py34197%63
nodestream_github/client
   githubclient.py2443088%93–94, 99–100, 193, 211, 247, 264, 330–331, 358–359, 420–421, 441–442, 477–478, 499–500, 512–513, 533–534, 543–544, 571–572, 592–593
TOTAL5593594% 

Tests Skipped Failures Errors Time
34 0 💤 0 ❌ 0 🔥 2.445s ⏱️

@jbristow jbristow merged commit 81b330d into master Mar 19, 2025
4 checks passed
@rreddy2 rreddy2 deleted the adding-audit-log branch March 19, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants