Update llhttp #691
Update llhttp #691
Conversation
| npm run build-wasm | ||
| ``` | ||
|
|
||
| #### Copy the sources to `undici` |
There was a problem hiding this comment.
All these steps could be condensed to:
cp build/llhttp/wasm/* <path-to-undici>/lib/llhttpIf we remove the embedding and use the llhttp project build. Just wanted to say that's an option if this is too clumsy.
There was a problem hiding this comment.
This guide should be revisited if/when we have to modify lhttp sources for whatever reason.
| cp src/native/api.h build/llhttp.h <your-path-to-undici>/deps/llhttp/include/ | ||
| ``` | ||
|
|
||
| #### Build the WebAssembly module in `undici` |
There was a problem hiding this comment.
Also this would not be needed of we didn't embed.
There was a problem hiding this comment.
Can we avoid embedding as of now?
There was a problem hiding this comment.
Yes, we can. We don't currently modify the source files. IMHO is a cleaner approach, as long as we don't have to customize it. One thing to consider is the direction the llhttp project will take towards wasm. For example, what if the only way to access the build would be by installing it as a dependency and use its .js API (as suggested in nodejs/llhttp#93)? Would we be open to that?
But regarding now, we would just have to run build-wasm in llhttp and copy the build/wasm folder contents in lib/llhttp.
* chore(deps): update llhttp to version 5.0.1 * docs(constributing): add llhttp update guide * docs(contributing): add docker disclaimer in llhttp guide
Fixes #690