Skip to content

fix: max-age=0 and no-cache must be considered "immediately stale" #4624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: max-age=0 and no-cache must be considered "immediately stale" #4624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/handler/cache-handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,9 +393,14 @@

const maxAge = cacheControlDirectives['max-age']
if (maxAge !== undefined) {
return maxAge > 0 ? maxAge * 1000 : undefined
return maxAge >= 0 ? maxAge * 1000 : undefined
}

const noCache = cacheControlDirectives['no-cache']
if (noCache !== undefined) {
return 0
}

Check failure on line 403 in lib/handler/cache-handler.js

View workflow job for this annotation

GitHub Actions / Lint 

Trailing spaces not allowed
if (typeof resHeaders.expires === 'string') {
// https://www.rfc-editor.org/rfc/rfc9111.html#section-5.3
const expiresDate = parseHttpDate(resHeaders.expires)
Expand Down
Loading