fix: set kBodyUsed only once

[Uzlopak]

@metcoder95 wdyt?
#3294

[codecov-commenter]

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.94%. Comparing base (7321451) to head (68e70d6).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/core/util.js	33.33%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4592   +/-   ##
=======================================
  Coverage   92.94%   92.94%           
=======================================
  Files         106      106           
  Lines       32973    32970    -3     
=======================================
- Hits        30646    30644    -2     
+ Misses       2327     2326    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Uzlopak]

@metcoder95

There is no code coverage. And i guess we can remove this code, because https://nodejs.org/api/stream.html#readablereadabledidread is existing since v14.

[metcoder95]

I believe the initial intention was to avoid tampering, but given that every stream is EE based, it shouldn’t be a problem (bad stream, bad implementation, up to caller).

I’m just more into keep it with this instead of creating another closure; the rest LGTM

[ronag]

This is wrong. It's not because of tampering but because otherwise the stream will start when registering a data listener.

[mcollina]

That code was added to avoid some edge case that could happen if on() was overwritten. (Like streams do)

I wonder why that code was added without a test.

@Uzlopak can you verify who added this?

@ronag do you recall?

[ronag]

This breaks

[ronag]

Streams will start the stream if on is called with 'data' that's why the EE prototype is used.

[Uzlopak]

Ok, but the thing is, that the code is not covered by unit tests.

[ronag]

Would be nice to have that fixed.