Skip to content

Disable SIMD for PPC64 architecture, add UNDICI_NO_WASM_SIMD env to facilitate testing#4530

Merged
Uzlopak merged 6 commits intomainfrom
no-simd-power
Sep 8, 2025
Merged

Disable SIMD for PPC64 architecture, add UNDICI_NO_WASM_SIMD env to facilitate testing#4530
Uzlopak merged 6 commits intomainfrom
no-simd-power

Conversation

@mcollina
Copy link
Copy Markdown
Member

@mcollina mcollina commented Sep 8, 2025

No description provided.

Copy link
Copy Markdown
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one moment?!

Comment thread lib/dispatcher/client-h1.js Outdated
Signed-off-by: Matteo Collina <[email protected]>
@mcollina
Copy link
Copy Markdown
Member Author

mcollina commented Sep 8, 2025

@Uzlopak fixed. Check again.

Comment thread lib/dispatcher/client-h1.js Outdated
Signed-off-by: Matteo Collina <[email protected]>
Signed-off-by: Matteo Collina <[email protected]>
Comment thread lib/dispatcher/client-h1.js Outdated
Comment thread lib/dispatcher/client-h1.js Outdated
Comment thread lib/dispatcher/client-h1.js Outdated
Comment thread lib/dispatcher/client-h1.js Outdated
Copy link
Copy Markdown
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Uzlopak
Copy link
Copy Markdown
Contributor

Uzlopak commented Sep 8, 2025

@richardlau
can you approve it again please?

@Uzlopak Uzlopak merged commit f182ff1 into main Sep 8, 2025
32 of 34 checks passed
@Uzlopak Uzlopak deleted the no-simd-power branch September 8, 2025 18:24
@github-actions github-actions Bot mentioned this pull request Sep 9, 2025
nodejs-github-bot pushed a commit to nodejs/node that referenced this pull request Oct 11, 2025
Original commit message:

    Fix scratch registers passed to mtvsrdd

    `ra` cannot be r0 as it will be interpreted as Operand(0)

    Change-Id: Idce58191f9d3578dc91dc4aa3872a0bf2939d8b3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6936113
    Commit-Queue: Milad Farazmand <[email protected]>
    Reviewed-by: Junliang Yan <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#102388}

Refs: v8/v8@2abc613
PR-URL: #60177
Refs: nodejs/undici#4530
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
richardlau added a commit to nodejs/node that referenced this pull request Nov 7, 2025
Original commit message:

    Fix scratch registers passed to mtvsrdd

    `ra` cannot be r0 as it will be interpreted as Operand(0)

    Change-Id: Idce58191f9d3578dc91dc4aa3872a0bf2939d8b3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6936113
    Commit-Queue: Milad Farazmand <[email protected]>
    Reviewed-by: Junliang Yan <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#102388}

Refs: v8/v8@2abc613
PR-URL: #60177
Refs: nodejs/undici#4530
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
aduh95 pushed a commit to nodejs/node that referenced this pull request Nov 11, 2025
Original commit message:

    Fix scratch registers passed to mtvsrdd

    `ra` cannot be r0 as it will be interpreted as Operand(0)

    Change-Id: Idce58191f9d3578dc91dc4aa3872a0bf2939d8b3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6936113
    Commit-Queue: Milad Farazmand <[email protected]>
    Reviewed-by: Junliang Yan <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#102388}

Refs: v8/v8@2abc613
PR-URL: #60177
Refs: nodejs/undici#4530
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
slagiewka pushed a commit to slagiewka/undici that referenced this pull request Feb 14, 2026
…acilitate testing (nodejs#4530)

* Disable SIMD for PPC64 architecture, add UNDICI_NO_WASM_SIMD env to facilitate testing

Signed-off-by: Matteo Collina <[email protected]>

* fixup

Signed-off-by: Matteo Collina <[email protected]>

* fixup

Signed-off-by: Matteo Collina <[email protected]>

* fixup

Signed-off-by: Matteo Collina <[email protected]>

* Update lib/dispatcher/client-h1.js

Co-authored-by: Aras Abbasi <[email protected]>

* Apply suggestions from code review

---------

Signed-off-by: Matteo Collina <[email protected]>
Co-authored-by: Aras Abbasi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants