Add ability to detect when MemoryCacheStore reaches max size #4224
+181
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelixVaughan
changed the title
mcollina
reviewed
May 18, 2025
test/memory-cache-store-size.js
Outdated
| @@ -0,0 +1,123 @@ | |||
| 'use strict' | |||
Member
There was a problem hiding this comment.
can you please move this test together to the others of the cache?
Contributor
Author
There was a problem hiding this comment.
Yes, I moved them to memory-cache-store-tests.js. Let me know if you had somewhere else in mind.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
This is addressing #4185
Rationale
Currently it's possible to configure a maxSize with MemoryCacheStore, but there isn't a way to detect when this max size has been exceeded.
Changes
Added methods to get size of a memory cache, and check whether it is overflowing as well as an event which is emitted when the cache is full. Also added tests and updated docs.
Features
sizegetter on MemoryCacheStoreisFullpublic method on MemoryCacheStoremaxSizeExceededevent on MemoryCacheStoreBug Fixes
N/A
Breaking Changes and Deprecations
N/A
Status