refactor!: drop interceptors #3390
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
approved these changes
Jul 3, 2024
Member
Author
|
I'm finding quite more hidden testing situations that might need to be sorted out; the cherry-pick sadly was not completely clean. |
Member
|
I don't think it's a lot of work to just re do it from beginning? |
Member
Author
|
There are a few tests that will be interesting to migrate to the new interceptor setup, but those will take more time so I'd skip them from now. But the cherry-pick didn't work as I expected, so I'll do it manually instead |
Member
Author
|
Will create a new one from scratch, the cherry-pick on this one went out of hand |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status