feat(v7)!: next

.github/workflows/bench.yml

@@ -12,7 +12,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout Code
-        uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0
+        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
         with:
           persist-credentials: false
           ref: ${{ github.base_ref }}
@@ -30,7 +30,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout Code
-        uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0
+        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
         with:
           persist-credentials: false
       - name: Setup Node

.github/workflows/codeql.yml

@@ -41,12 +41,12 @@ jobs:
 
     steps:
       - name: Harden Runner
-        uses: step-security/harden-runner@1b05615854632b887b69ae1be8cbefe72d3ae423 # v2.6.0
+        uses: step-security/harden-runner@63c24ba6bd7ba022e95695ff85de572c04a18142 # v2.7.0
         with:
           egress-policy: audit
 
       - name: Checkout repository
-        uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0
+        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
 
       # Initializes the CodeQL tools for scanning.
       - name: Initialize CodeQL

.github/workflows/dependency-review.yml

@@ -17,11 +17,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Harden Runner
-        uses: step-security/harden-runner@1b05615854632b887b69ae1be8cbefe72d3ae423 # v2.6.0
+        uses: step-security/harden-runner@63c24ba6bd7ba022e95695ff85de572c04a18142 # v2.7.0
         with:
           egress-policy: audit
 
       - name: 'Checkout Repository'
-        uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0
+        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
       - name: 'Dependency Review'
         uses: actions/dependency-review-action@4901385134134e04cec5fbe5ddfe3b2c5bd5d976 # v4.0.0

.github/workflows/fuzz.yml

@@ -11,7 +11,7 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0
+      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
         with:
           persist-credentials: false
 
@@ -29,7 +29,7 @@ jobs:
         run: |
           npm run fuzz
 
-      - uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
+      - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
         if: ${{ failure() }}
         with:
           name: undici-fuzz-results-${{ github.sha }}

.github/workflows/lint.yml

@@ -7,7 +7,7 @@ jobs:
   lint:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0
+      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
         with:
           persist-credentials: false
       - uses: actions/setup-node@b39b52d1213e96004bfcb1c61a8a6fa8ab84f3e8 # v4.0.1

.github/workflows/publish-undici-types.yml

@@ -13,7 +13,7 @@ jobs:
   publish:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0
+      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
       - uses: actions/setup-node@b39b52d1213e96004bfcb1c61a8a6fa8ab84f3e8 # v4.0.1
         with:
           node-version: '16.x'

.github/workflows/scorecard.yml

@@ -29,7 +29,7 @@ jobs:
 
     steps:
       - name: "Checkout code"
-        uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0
+        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
         with:
           persist-credentials: false
 
@@ -43,7 +43,7 @@ jobs:
       # Upload the results as artifacts (optional). Commenting out will disable uploads of run results in SARIF
       # format to the repository Actions tab.
       - name: "Upload artifact"
-        uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
+        uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
         with:
           name: SARIF file
           path: results.sarif

README.md

@@ -17,23 +17,31 @@ npm i undici
 
 ## Benchmarks
 
-The benchmark is a simple `hello world` [example](benchmarks/benchmark.js) using a
-50 TCP connections with a pipelining depth of 10 running on Node 20.10.0.
+The benchmark is a simple `hello world` [example](benchmarks/benchmark.js) using:
+
+* 50 TCP connections
+* A pipelining factor of 10 for undici
+* 200 parallel requests issued per iteration (sample)
+
+The benchmark was run on Linux on top of Node 20.10.0.
 
 ```
-│ Tests               │ Samples │          Result │ Tolerance │ Difference with slowest │
-|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
-│ got                 │      45 │ 1661.71 req/sec │  ± 2.93 % │                       - │
-│ node-fetch          │      20 │ 2164.81 req/sec │  ± 2.63 % │               + 30.28 % │
-│ undici - fetch      │      35 │ 2274.27 req/sec │  ± 2.70 % │               + 36.86 % │
-│ http - no keepalive │      15 │ 2376.04 req/sec │  ± 2.99 % │               + 42.99 % │
-│ axios               │      25 │ 2612.93 req/sec │  ± 2.89 % │               + 57.24 % │
-│ request             │      40 │ 2712.19 req/sec │  ± 2.92 % │               + 63.22 % │
-│ http - keepalive    │      45 │ 4393.25 req/sec │  ± 2.86 % │              + 164.38 % │
-│ undici - pipeline   │      45 │ 5484.69 req/sec │  ± 2.87 % │              + 230.06 % │
-│ undici - request    │      55 │ 7773.98 req/sec │  ± 2.93 % │              + 367.83 % │
-│ undici - stream     │      70 │ 8425.96 req/sec │  ± 2.91 % │              + 407.07 % │
-│ undici - dispatch   │      50 │ 9488.99 req/sec │  ± 2.85 % │              + 471.04 % │
+┌─────────┬───────────────────────┬─────────┬────────────────────┬────────────┬─────────────────────────┐
+│ (index) │         Tests         │ Samples │       Result       │ Tolerance  │ Difference with slowest │
+├─────────┼───────────────────────┼─────────┼────────────────────┼────────────┼─────────────────────────┤
+│    0    │         'got'         │   25    │ '3444.59 req/sec'  │ '± 2.88 %' │           '-'           │
+│    1    │     'node-fetch'      │   20    │ '4927.30 req/sec'  │ '± 2.46 %' │       '+ 43.04 %'       │
+│    2    │   'undici - fetch'    │   10    │ '5043.80 req/sec'  │ '± 1.87 %' │       '+ 46.43 %'       │
+│    3    │       'request'       │   35    │ '6389.13 req/sec'  │ '± 2.93 %' │       '+ 85.48 %'       │
+│    4    │        'axios'        │   25    │ '6920.61 req/sec'  │ '± 2.76 %' │      '+ 100.91 %'       │
+│    5    │ 'http - no keepalive' │   10    │ '9357.37 req/sec'  │ '± 2.24 %' │      '+ 171.65 %'       │
+│    6    │  'http - keepalive'   │   30    │ '9921.36 req/sec'  │ '± 2.83 %' │      '+ 188.03 %'       │
+│    7    │     'superagent'      │   10    │ '10118.35 req/sec' │ '± 2.18 %' │      '+ 193.75 %'       │
+│    8    │  'undici - pipeline'  │   10    │ '17106.69 req/sec' │ '± 1.46 %' │      '+ 396.62 %'       │
+│    9    │  'undici - request'   │   20    │ '21611.80 req/sec' │ '± 2.50 %' │      '+ 527.41 %'       │
+│   10    │   'undici - stream'   │   10    │ '24282.13 req/sec' │ '± 1.94 %' │      '+ 604.94 %'       │
+│   11    │  'undici - dispatch'  │   20    │ '24441.95 req/sec' │ '± 2.68 %' │      '+ 609.58 %'       │
+└─────────┴───────────────────────┴─────────┴────────────────────┴────────────┴─────────────────────────┘
 ```
 
 ## Quick Start

benchmarks/TernarySearchTree.mjs

@@ -0,0 +1,20 @@
+import { bench, group, run } from 'mitata'
+import { tree } from '../lib/core/tree.js'
+
+const contentLength = Buffer.from('Content-Length')
+const contentLengthUpperCase = Buffer.from('Content-Length'.toUpperCase())
+const contentLengthLowerCase = Buffer.from('Content-Length'.toLowerCase())
+
+group('tree.search', () => {
+  bench('content-length', () => {
+    tree.lookup(contentLengthLowerCase)
+  })
+  bench('CONTENT-LENGTH', () => {
+    tree.lookup(contentLengthUpperCase)
+  })
+  bench('Content-Length', () => {
+    tree.lookup(contentLength)
+  })
+})
+
+await run()

benchmarks/benchmark-http2.js

@@ -1,7 +1,5 @@
 'use strict'
 
-const { connect } = require('node:http2')
-const { createSecureContext } = require('node:tls')
 const os = require('node:os')
 const path = require('node:path')
 const { readFileSync } = require('node:fs')
@@ -48,11 +46,6 @@ const httpsBaseOptions = {
   ...dest
 }
 
-const http2ClientOptions = {
-  secureContext: createSecureContext({ ca }),
-  servername
-}
-
 const undiciOptions = {
   path: '/',
   method: 'GET',
@@ -113,7 +106,9 @@ class SimpleRequest {
 }
 
 function makeParallelRequests (cb) {
-  return Promise.all(Array.from(Array(parallelRequests)).map(() => new Promise(cb)))
+  const res = Promise.all(Array.from(Array(parallelRequests)).map(() => new Promise(cb)))
+  res.catch(console.error)
+  return res
 }
 
 function printResults (results) {
@@ -143,10 +138,12 @@ function printResults (results) {
         last = mean
       }
 
+      console.log(mean)
+
       return {
         Tests: name,
         Samples: size,
-        Result: `${((connections * 1e9) / mean).toFixed(2)} req/sec`,
+        Result: `${((1e9 * parallelRequests) / mean).toFixed(2)} req/sec`,
         Tolerance: `± ${((standardError / mean) * 100).toFixed(2)} %`,
         'Difference with slowest': relative > 0 ? `+ ${relative.toFixed(2)} %` : '-'
       }
@@ -156,28 +153,6 @@ function printResults (results) {
 }
 
 const experiments = {
-  'http2 - request' () {
-    return makeParallelRequests(resolve => {
-      connect(dest.url, http2ClientOptions, (session) => {
-        const headers = {
-          ':path': '/',
-          ':method': 'GET',
-          ':scheme': 'https',
-          ':authority': `localhost:${dest.port}`
-        }
-
-        const request = session.request(headers)
-
-        request.pipe(
-          new Writable({
-            write (chunk, encoding, callback) {
-              callback()
-            }
-          })
-        ).on('finish', resolve)
-      })
-    })
-  },
   'undici - pipeline' () {
     return makeParallelRequests(resolve => {
       dispatcher

benchmarks/benchmark-https.js

@@ -160,7 +160,7 @@ function printResults (results) {
       return {
         Tests: name,
         Samples: size,
-        Result: `${((connections * 1e9) / mean).toFixed(2)} req/sec`,
+        Result: `${((parallelRequests * 1e9) / mean).toFixed(2)} req/sec`,
         Tolerance: `± ${((standardError / mean) * 100).toFixed(2)} %`,
         'Difference with slowest': relative > 0 ? `+ ${relative.toFixed(2)} %` : '-'
       }

benchmarks/benchmark.js

@@ -175,7 +175,7 @@ function printResults (results) {
       return {
         Tests: name,
         Samples: size,
-        Result: `${((connections * 1e9) / mean).toFixed(2)} req/sec`,
+        Result: `${((parallelRequests * 1e9) / mean).toFixed(2)} req/sec`,
         Tolerance: `± ${((standardError / mean) * 100).toFixed(2)} %`,
         'Difference with slowest': relative > 0 ? `+ ${relative.toFixed(2)} %` : '-'
       }

benchmarks/cacheGetFieldValues.mjs

@@ -0,0 +1,23 @@
+import { bench, group, run } from 'mitata'
+import { getFieldValues } from '../lib/web/cache/util.js'
+
+const values = [
+  '',
+  'foo',
+  'invälid',
+  'foo, ',
+  'foo, bar',
+  'foo, bar, baz',
+  'foo, bar, baz, ',
+  'foo, bar, baz, , '
+]
+
+group('getFieldValues', () => {
+  bench('getFieldValues', () => {
+    for (let i = 0; i < values.length; ++i) {
+      getFieldValues(values[i])
+    }
+  })
+})
+
+await run()

benchmarks/headers-length32.mjs

@@ -0,0 +1,56 @@
+import { bench, run } from 'mitata'
+import { Headers } from '../lib/web/fetch/headers.js'
+
+const headers = new Headers(
+  [
+    'Origin-Agent-Cluster',
+    'RTT',
+    'Accept-CH-Lifetime',
+    'X-Frame-Options',
+    'Sec-CH-UA-Platform-Version',
+    'Digest',
+    'Cache-Control',
+    'Sec-CH-UA-Platform',
+    'If-Range',
+    'SourceMap',
+    'Strict-Transport-Security',
+    'Want-Digest',
+    'Cross-Origin-Resource-Policy',
+    'Width',
+    'Accept-CH',
+    'Via',
+    'Refresh',
+    'Server',
+    'Sec-Fetch-Dest',
+    'Sec-CH-UA-Model',
+    'Access-Control-Request-Method',
+    'Access-Control-Request-Headers',
+    'Date',
+    'Expires',
+    'DNT',
+    'Proxy-Authorization',
+    'Alt-Svc',
+    'Alt-Used',
+    'ETag',
+    'Sec-Fetch-User',
+    'Sec-CH-UA-Full-Version-List',
+    'Referrer-Policy'
+  ].map((v) => [v, ''])
+)
+
+const kHeadersList = Reflect.ownKeys(headers).find(
+  (c) => String(c) === 'Symbol(headers list)'
+)
+
+const headersList = headers[kHeadersList]
+
+const kHeadersSortedMap = Reflect.ownKeys(headersList).find(
+  (c) => String(c) === 'Symbol(headers map sorted)'
+)
+
+bench('Headers@@iterator', () => {
+  headersList[kHeadersSortedMap] = null
+  return [...headers]
+})
+
+await run()

benchmarks/headers.mjs

@@ -0,0 +1,57 @@
+import { bench, group, run } from 'mitata'
+import { Headers } from '../lib/web/fetch/headers.js'
+
+const characters = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789'
+const charactersLength = characters.length
+
+function generateAsciiString (length) {
+  let result = ''
+  for (let i = 0; i < length; ++i) {
+    result += characters[Math.floor(Math.random() * charactersLength)]
+  }
+  return result
+}
+
+const settings = {
+  'fast-path (tiny array)': 4,
+  'fast-path (small array)': 8,
+  'fast-path (middle array)': 16,
+  'fast-path': 32,
+  'slow-path': 64
+}
+
+for (const [name, length] of Object.entries(settings)) {
+  const headers = new Headers(
+    Array.from(Array(length), () => [generateAsciiString(12), ''])
+  )
+
+  const headersSorted = new Headers(headers)
+
+  const kHeadersList = Reflect.ownKeys(headers).find(
+    (c) => String(c) === 'Symbol(headers list)'
+  )
+
+  const headersList = headers[kHeadersList]
+
+  const headersListSorted = headersSorted[kHeadersList]
+
+  const kHeadersSortedMap = Reflect.ownKeys(headersList).find(
+    (c) => String(c) === 'Symbol(headers map sorted)'
+  )
+
+  group(`length ${length} #${name}`, () => {
+    bench('Headers@@iterator', () => {
+      // prevention of memoization of results
+      headersList[kHeadersSortedMap] = null
+      return [...headers]
+    })
+
+    bench('Headers@@iterator (sorted)', () => {
+      // prevention of memoization of results
+      headersListSorted[kHeadersSortedMap] = null
+      return [...headersSorted]
+    })
+  })
+}
+
+await run()