Skip to content

Conversation

@mcollina
Copy link
Member

cc @nodejs/streams

@mcollina mcollina requested a review from calvinmetcalf May 28, 2017 11:57
Copy link
Contributor

@calvinmetcalf calvinmetcalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blah blah test churn looks good assuming the tests pass

@mcollina
Copy link
Member Author

@calvinmetcalf there was a verify high number of breakages due to npm and some things that were not transpiled.

@mcollina
Copy link
Member Author

@calvinmetcalf
Copy link
Contributor

ah looks like they stoped supporting 0.10?

@mcollina
Copy link
Member Author

@zkat can you have a look here? it used to work :(.

@zkat
Copy link

zkat commented Jun 1, 2017

@mcollina we do not support, at all, any versions of node older than node@4. Only node versions still in maintenance are targeted, and we've started intentionally breaking compatibility now.

@mcollina
Copy link
Member Author

mcollina commented Jun 1, 2017

@zkat You mean that npm@lts is not supported anymore? what about npm@latest-3?

@zkat
Copy link

zkat commented Jun 1, 2017

@mcollina I guess lts and 3 would probably still work, but this stuff isn't really supposed to run on [email protected]. It looks like we officially took out 0.10 support with [email protected], and dropped 0.12 support as of [email protected].

@mcollina
Copy link
Member Author

mcollina commented Jun 1, 2017

@zkat we are now using npm@2 and npm@latest-3 in the unsupported versions of Node. Things are passing again now :).

@mcollina
Copy link
Member Author

mcollina commented Jun 1, 2017

@calvinmetcalf I disabled the new test/parallel/test-stream-unpipe-event.js in Node v0.8 as it was not passing. I don't think there is any value in fixing it.

@calvinmetcalf
Copy link
Contributor

ok what was the issue with unpipe events ?

@mcollina
Copy link
Member Author

mcollina commented Jun 1, 2017

This is the relative PR: nodejs/node#11876. I do not know why it does not pass on node 0.8.

@calvinmetcalf
Copy link
Contributor

ok looks like the test may have been wonky? I don't know lgtm

@mcollina mcollina merged commit 448cdc2 into master Jun 2, 2017
@mcollina mcollina deleted the bump-7.10.0 branch June 2, 2017 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants