Skip to content

Conversation

@rakleed
Copy link
Contributor

@rakleed rakleed commented Sep 29, 2022

Make dark scroll bar in dark theme

@Trott
Copy link
Member

Trott commented Sep 29, 2022

I'm not seeing anything different with this change. Can you share a screenshot showing the before/after and indicate what browser/OS you're using?

@rakleed
Copy link
Contributor Author

rakleed commented Sep 29, 2022

I'm new to SCSS, but I've built it, fixed it, and now it works.

You need a Chromium-based browser and that the scroll bar is always displayed (there should be such an option in the system settings).

Before

image

After

image

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SEWeiTung SEWeiTung enabled auto-merge (squash) October 4, 2022 02:14
@SEWeiTung SEWeiTung merged commit 8b4e304 into nodejs:main Oct 4, 2022
@SEWeiTung
Copy link
Contributor

Thank @rakleed for your contribution to UI, it looks nicer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants