asynchronously loading the webfont + caching it #139
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: layouts/partials/footer.hbs layouts/partials/html-head.hbs
Contributor
|
@fhemberger this was rebased I think to resolve the merge conflicts. you had reviewed the prior patch, does this one look ok? |
Contributor
|
I only had a quick glance at the original patch (looked okay to me so far). Still, I'd like to have a closer look and reserve some time for testing. |
Contributor
|
This whole XHR + localStorage stuff seems a bit excessive to me. Can't we just rely on native browser caching? |
Contributor
|
Opened #178 for my attempt at this. |
Contributor
|
Guess this one is kind of obsolete now with aa4b373. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #69 by @ddprrt had some conflicts, I rebased it and am pushing again.
This should close #108.