Download buttons on home page open NGINX file viewer

[mikeesto]

URL:

https://nodejs.org/en/

Browser Name:

Chrome

Browser Version:

v110

Operation System:

MacOS

How to reproduce the issue:

On the home page, clicking on the download buttons for LTS or Current opens the NGINX (?) file viewer instead of downloading the file for my operating system.

[ovflowd]

This is really odd. And it’s supposed to be working. Thank you for reporting, @mikeesto.

If you’d like to work on this issue that’d be great! Otherwise I can look into it first thing tomorrow :)

[mikeesto]

I've had a very quick look and it actually works as intended when I'm running it locally, so I'm not sure what is going on tbh

[Trott]

If I don't click on a button and instead copy the link and paste it into the URL bar on the browser, it works as expected. This is really odd. Maybe @richardlau might have some idea what's going on here?

[Trott]

If instead of clicking the button, I right click and open in a new tab, it also works as expected!

[richardlau]

If I look at the page source I see this

i.e. the href is pointing to https://nodejs.org/dist/v18.15.0/ despite my browser suggesting the link would open https://nodejs.org/dist/v18.15.0/node-v18.15.0-x64.msi when I hover my mouse over the button 🤷

[mikeesto]

Very odd. I tried deploying a copy of this repo to Vercel and it works fine there - the href source code looks correct too

[yamitsushi]

the link somehow directs to https://nodejs.org/dist/v18.15.0node-v18.15.0-x64.msi
it should be https://nodejs.org/dist/v18.15.0/node-v18.15.0-x64.msi

see the missing '/' on the link

[richardlau]

FWIW If I remove the circled event listeners, left clicking on the link downloads the msi file.

[ovflowd]

If I recall correctly our legacy scripts detect the OS and basically formulate the download link, they then inject via DOM the new link, which is probably conflicting with React or Next.js. The idea in the future of course is to get rid of that vanilla JS file once we start migrating to the new layout.

I'll check if for now there's any workaround we can do to fix this, as I feel these event listeners come from the next/link component.