Skip to content

Conversation

@nanocloudx
Copy link
Contributor

@nanocloudx nanocloudx commented Nov 12, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
  • doc
Description of change

fix doc/tls.md: line 762 836 1026 e.g., => e.g.

Fixes: nodejs/code-and-learn#58

fix doc/tls.md: line 762 836 1026 e.g., => e.g.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem. labels Nov 12, 2016
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shigeki pushed a commit that referenced this pull request Nov 13, 2016
fix doc/tls.md: line 762 836 1026 e.g., => e.g.

Fixes: nodejs/code-and-learn#58
PR-URL: #9566
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
@shigeki
Copy link
Contributor

shigeki commented Nov 13, 2016

Thanks. Landed in 9428854.
Congrats on your first contribution to Node.

@shigeki shigeki closed this Nov 13, 2016
Fishrock123 pushed a commit that referenced this pull request Nov 22, 2016
fix doc/tls.md: line 762 836 1026 e.g., => e.g.

Fixes: nodejs/code-and-learn#58
PR-URL: #9566
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 13, 2016
fix doc/tls.md: line 762 836 1026 e.g., => e.g.

Fixes: nodejs/code-and-learn#58
PR-URL: #9566
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
fix doc/tls.md: line 762 836 1026 e.g., => e.g.

Fixes: nodejs/code-and-learn#58
PR-URL: #9566
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code And Learn at NodeFest 2016

7 participants