Skip to content

test: move tick-processor tests to own directory #9506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 5 commits into from
Closed

test: move tick-processor tests to own directory #9506

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7cf7645
test: move tick-processor tests to own directory
Trott Nov 7, 2016
15f1f47
squash: remove parallel.status entry
Trott Nov 7, 2016
b0d62a4
squash: add README info
Trott Nov 8, 2016
c6e0499
squash: v8 -> V8
Trott Nov 8, 2016
e6aaa3d
squash: inspector -> tick-processor
Trott Nov 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,9 @@ test-debugger: all
test-inspector: all
$(PYTHON) tools/test.py inspector

test-tick-processor: all
$(PYTHON) tools/test.py tick-processor

test-known-issues: all
$(PYTHON) tools/test.py known_issues

Expand Down
1 change: 0 additions & 1 deletion test/parallel/parallel.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ prefix parallel
[$arch==arm || $arch==arm64]

[$system==solaris] # Also applies to SmartOS
test-tick-processor-unknown: PASS,FLAKY

[$system==freebsd]

Expand Down
0 test/parallel/test-tick-processor-builtin.js → ...-processor/test-tick-processor-builtin.js
View file
Open in desktop
File renamed without changes.
0 .../parallel/test-tick-processor-cpp-core.js → ...processor/test-tick-processor-cpp-core.js
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions test/parallel/test-tick-processor-unknown.js → ...-processor/test-tick-processor-unknown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
const common = require('../common');

// TODO(mhdawson) Currently the test-tick-processor functionality in V8
// depends on addresses being smaller than a full 64 bits. Aix supports
// depends on addresses being smaller than a full 64 bits. AIX supports
// the full 64 bits and the result is that it does not process the
// addresses correctly and runs out of memory
// Disabling until we get a fix upstreamed into V8
if (common.isAix) {
common.skip('Aix address range too big for scripts.');
common.skip('AIX address range too big for scripts.');
return;
}

Expand All @@ -21,7 +21,7 @@ const base = require('./tick-processor-base.js');
// Unknown checked for to prevent flakiness, if pattern is not found,
// then a large number of unknown ticks should be present
base.runTest({
pattern: /LazyCompile.*\[eval\]:1|.*% UNKNOWN/,
pattern: /LazyCompile.*\[eval]:1|.*% UNKNOWN/,
Copy link

@matthewloring matthewloring Nov 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed?

Copy link
Member Author

@Trott Trott Nov 8, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

] does not need to be escaped in a regular expression unless it occurs in a character class. I've been removing unnecessary escaping (especially in regular expressions) when I touch a file lately. I can put it back if you or anyone else thinks the regular expression is easier to read with it.

Copy link

@matthewloring matthewloring Nov 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally find the explicit escaping more readable but I don't feel too strongly about it.

code: `function f() {
for (var i = 0; i < 1000000; i++) {
i++;
Expand Down
6 changes: 6 additions & 0 deletions test/tick-processor/testcfg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import sys, os
sys.path.append(os.path.join(os.path.dirname(__file__), '..'))
import testpy

def GetConfiguration(context, root):
return testpy.SimpleTestConfiguration(context, root, 'tick-processor')
0 test/parallel/tick-processor-base.js → test/tick-processor/tick-processor-base.js
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions vcbuild.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ if /i "%1"=="test-simple" set test_args=%test_args% sequential parallel -J&got
if /i "%1"=="test-message" set test_args=%test_args% message&goto arg-ok
if /i "%1"=="test-gc" set test_args=%test_args% gc&set buildnodeweak=1&goto arg-ok
if /i "%1"=="test-inspector" set test_args=%test_args% inspector&goto arg-ok
if /i "%1"=="test-tick-processor" set test_args=%test_args% tick-processor&goto arg-ok
if /i "%1"=="test-internet" set test_args=%test_args% internet&goto arg-ok
if /i "%1"=="test-pummel" set test_args=%test_args% pummel&goto arg-ok
if /i "%1"=="test-all" set test_args=%test_args% sequential parallel message gc inspector internet pummel&set buildnodeweak=1&set jslint=1&goto arg-ok
Expand Down