Skip to content

Conversation

@maasencioh
Copy link
Contributor

Checklist
  • commit message follows commit guidelines
Description of change

Ref: #8913

@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Oct 12, 2016


IncomingMessage.prototype._addHeaderLines = function(headers, n) {
IncomingMessage.prototype._addHeaderLines = function _addHeaderLines(headers, n) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the lines don't exceed 80 characters. make jslint should help you spot the long lines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a silly question, but I want to keep the style, should I do

IncomingMessage.prototype._addHeaderLines =
    function _addHeaderLines(headers, n) {...};

or

function _addHeaderLines(headers, n) {...}
IncomingMessage.prototype._addHeaderLines = _addHeaderLines;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

http Issues or PRs related to the http subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants