Skip to content

build: fix config.gypi target #9053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 3 commits into from
Closed

build: fix config.gypi target #9053

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23914d0
build: fix config.gypi target
danbev Oct 12, 2016
75ec3fb
add single error message for both missing and stale
danbev Oct 12, 2016
2a093fd
correct error message for both Missing/Stale config.gypi
danbev Oct 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,7 @@ out/Makefile: common.gypi deps/uv/uv.gyp deps/http_parser/http_parser.gyp \
$(PYTHON) tools/gyp_node.py -f make

config.gypi: configure
if [ -f $@ ]; then
$(error Stale $@, please re-run ./configure)
else
$(error No $@, please run ./configure first)
fi
$(error Missing or stale $@, please re-run ./$<)
Copy link
Member

@bnoordhuis bnoordhuis Oct 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiniest of nits: maybe s/re-run/run/ - in the 'missing' case, you probably haven't run configure before.

Copy link
Contributor Author

@danbev danbev Oct 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks


install: all
$(PYTHON) tools/install.py $@ '$(DESTDIR)' '$(PREFIX)'
Expand Down