Skip to content

v6.x backport: fs: make SyncWriteStream inherit from Writable #9030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
addaleax wants to merge 1 commit into from
Closed

v6.x backport: fs: make SyncWriteStream inherit from Writable #9030

addaleax wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

@addaleax addaleax commented Oct 11, 2016

Backport #8830 to v6.x

btw, the linter is failing for me with unrelated changes:

/home/sqrt/src/node/benchmark/common.js
  266:1  error  Too many blank lines at the end of file. Max of 0 allowed  no-multiple-empty-lines

/home/sqrt/src/node/benchmark/http/http_server_for_chunky_client.js
  55:1  error  Too many blank lines at the end of file. Max of 0 allowed  no-multiple-empty-lines

/home/sqrt/src/node/benchmark/idle_clients.js
  48:1  error  Too many blank lines at the end of file. Max of 0 allowed  no-multiple-empty-lines

/home/sqrt/src/node/test/parallel/test-readline-interface.js
  393:7  error  Function argument in column 7, expected in 16  align-function-arguments
  395:7  error  Function argument in column 7, expected in 16  align-function-arguments

✖ 5 problems (5 errors, 0 warnings)

/cc @Fishrock123

@addaleax
fs: make SyncWriteStream inherit from Writable
55e9c3a 
Make the internal `SyncWriteStream` a proper `stream.Writable`
subclass. This allows for quite a bit of simplification, since
`SyncWriteStream` predates the streams2/streams3 implementations.

Fixes: nodejs#8828
PR-URL: nodejs#8830
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. v6.x labels Oct 11, 2016
@addaleax addaleax added semver-minor PRs that contain new features and should be released in the next minor version. stream Issues and PRs related to the stream subsystem. process Issues and PRs related to the process subsystem. labels Oct 11, 2016
@addaleax
Copy link
Member Author

addaleax commented Oct 11, 2016

CI: https://ci.nodejs.org/job/node-test-commit/5546/

@Fishrock123
Copy link
Contributor

Fishrock123 commented Oct 11, 2016

the lint errors will be fixed in #9029

@Fishrock123
Copy link
Contributor

Fishrock123 commented Oct 11, 2016

Looks like a windows test crashed... bit concerning.

not ok 301 message/max_tick_depth
# CRASHED

@Fishrock123
Copy link
Contributor

Fishrock123 commented Oct 11, 2016

re-running windows tests: https://ci.nodejs.org/job/node-test-commit-windows-fanned/4790/

@Fishrock123
Copy link
Contributor

Fishrock123 commented Oct 11, 2016 •
edited
Loading

Looks good. Landing.

Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@addaleax @Fishrock123
fs: make SyncWriteStream inherit from Writable
688abac 
Make the internal `SyncWriteStream` a proper `stream.Writable`
subclass. This allows for quite a bit of simplification, since
`SyncWriteStream` predates the streams2/streams3 implementations.

Fixes: #8828
PR-URL: #8830
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>

(backport info)
Refs: #9030
@Fishrock123
Copy link
Contributor

Fishrock123 commented Oct 11, 2016

Landed in 688abac -- thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Fishrock123 Fishrock123 Fishrock123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fs Issues and PRs related to the fs subsystem / file system. process Issues and PRs related to the process subsystem. semver-minor PRs that contain new features and should be released in the next minor version. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@addaleax @Fishrock123 @nodejs-github-bot