Skip to content

Conversation

@eugeneo
Copy link
Contributor

@eugeneo eugeneo commented Sep 23, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

inspector: gyp file was updated.

Description of change

Remove obsolete build file entries.

@nodejs-github-bot nodejs-github-bot added the inspector Issues and PRs related to the V8 inspector protocol label Sep 23, 2016
@mscdex mscdex added the build Issues and PRs related to build files or the CI. label Sep 23, 2016
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@imyller imyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eugeneo pushed a commit that referenced this pull request Sep 26, 2016
Remove obsolete build file entries.

Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ilkka Myller <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #8753
@eugeneo eugeneo closed this Sep 26, 2016
@eugeneo
Copy link
Contributor Author

eugeneo commented Sep 26, 2016

Landed as 292040f

MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Sep 28, 2016
Remove obsolete build file entries.

Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ilkka Myller <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: nodejs#8753
jasnell pushed a commit that referenced this pull request Sep 29, 2016
Remove obsolete build file entries.

Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ilkka Myller <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #8753
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
Remove obsolete build file entries.

Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ilkka Myller <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #8753
geek pushed a commit to geek/node that referenced this pull request Sep 30, 2016
Remove obsolete build file entries.

Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ilkka Myller <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: nodejs#8753
@eugeneo eugeneo deleted the remove_unused branch October 13, 2016 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. inspector Issues and PRs related to the V8 inspector protocol

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants