inspector: address race conditions #8672
Conversation
nodejs-github-bot
added
c++
eugeneo
changed the title
eugeneo
changed the title
|
This is CI result for running this test 500 times on each platform - https://ci.nodejs.org/job/node-stress-single-test/949/ There are failures on PI platforms, but I doubt they are caused by this change. Please take another look. |
Stress tests uncovered 2 race conditions, when IO events happened during V8 entering event loop on pause or during Node.js shutdown. Fixes: #8669
|
I have reworked this patch a bit. I got rid of the second mutex, slightly renamed variables and extracted blocks into properly named functions. Please take another look. CI: https://ci.nodejs.org/job/node-test-pull-request/4224/ |
|
lgtm! |
|
Thank you for the review. Last CI: https://ci.nodejs.org/job/node-test-pull-request/4224/ |
|
Landed as 5acbeb0 |
Stress tests uncovered 2 race conditions, when IO events happened during V8 entering event loop on pause or during Node.js shutdown. Fixes: #8669 PR-URL: #8672 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Aleksey Kozyatinskiy <[email protected]>
|
@eugeneo Can you use a full URL in the Fixes: tag next time? |
|
Will do. |
Stress tests uncovered 2 race conditions, when IO events happened during V8 entering event loop on pause or during Node.js shutdown. Fixes: nodejs#8669 PR-URL: nodejs#8672 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Aleksey Kozyatinskiy <[email protected]>
Stress tests uncovered 2 race conditions, when IO events happened during V8 entering event loop on pause or during Node.js shutdown. Fixes: #8669 PR-URL: #8672 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Aleksey Kozyatinskiy <[email protected]>
Stress tests uncovered 2 race conditions, when IO events happened during V8 entering event loop on pause or during Node.js shutdown. Fixes: #8669 PR-URL: #8672 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Aleksey Kozyatinskiy <[email protected]>
5 participants
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
inspector: bugfix
Description of change
There seems to be a race condition, when inspector receives message that
the frontend had disconnected while the runtime is shutting down.
Fixes: #8669
CC: @Trott @ofrobots