Skip to content

[WIP] Update V8 to 5.2 #7824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 8 commits into from
Closed

[WIP] Update V8 to 5.2 #7824

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1399906
deps: update V8 5.2.361.46
targos Jul 21, 2016
8c13873
tools: do not disable ICU's transliteration
targos Jun 30, 2016
2d7abd9
build: update V8 gypfile paths
targos Jun 30, 2016
e19f71b
v8: warn in Template::Set() on improper use
bnoordhuis Apr 19, 2016
9225758
deps: cherry-pick 2b4c9c1 from v8 upstream
joransiu Jul 17, 2016
c3d8bcf
temporarily remove proxy test
targos Jul 21, 2016
406dd07
attempt to fix freebsd compilation
targos Jul 26, 2016
e6ac388
remove crash instrumentation to fix smartos64 build
targos Jul 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tools/icu/icu-generic.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
}],
],
'defines': [
'UCONFIG_NO_TRANSLITERATION=1',
'UCONFIG_NO_SERVICE=1',
Copy link
Member

@srl295 srl295 Jul 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the v8 version visible as a parameter here? Perhaps we could parameterize this… same with the data.

'UCONFIG_NO_REGULAR_EXPRESSIONS=1',
'U_ENABLE_DYLOAD=0',
Expand Down
2 changes: 1 addition & 1 deletion tools/icu/icu_small.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"zone": "locales",
"converters": "none",
"stringprep": "locales",
"translit": "none",
"translit": "locales",
Copy link
Member

@srl295 srl295 Jul 27, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah - "locales" may not be quite right here in fact. It's more complex which is why I'd like a separate issue tracking this (translit enablement for v8) For now, I'd actually remove the translit line altogether from this file.

"brkfiles": "none",
"brkdict": "none",
"confusables": "none",
Expand Down