Skip to content

doc: fix exec stdout & stderr default type in child_process #7361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sartrey wants to merge 3 commits into from
Closed

doc: fix exec stdout & stderr default type in child_process #7361

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2fc57a2
fix doc about child_process exec & execFile
sartrey Jun 22, 2016
9e7ed79
fix words & wrap lines at almost 80 charaters
sartrey Jun 23, 2016
9ba085a
exactly wrap at 80 chars
sartrey Jun 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/api/child_process.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ The `stdout` and `stderr` arguments passed to the callback will contain the
stdout and stderr output of the child process. By default, Node.js will decode
the output as UTF-8 and pass strings to the callback. The `encoding` option
can be used to specify the character encoding used to decode the stdout and
stderr output. If `encoding` is `'buffer'`, `Buffer` objects will be passed to
stderr output. If `encoding` is `'buffer'` (or not a valid Buffer encoding), `Buffer` objects will be passed to
Copy link
Contributor

@cjihrig cjihrig Jun 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should say something like:

If encoding is 'buffer', or an unrecognized character encoding, Buffer objects will be passed to

Copy link
Contributor

@cjihrig cjihrig Jun 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please wrap lines at 80 characters.

the callback instead.

The `options` argument may be passed as the second argument to customize how
Expand Down Expand Up @@ -233,7 +233,7 @@ The `stdout` and `stderr` arguments passed to the callback will contain the
stdout and stderr output of the child process. By default, Node.js will decode
the output as UTF-8 and pass strings to the callback. The `encoding` option
can be used to specify the character encoding used to decode the stdout and
stderr output. If `encoding` is `'buffer'`, `Buffer` objects will be passed to
stderr output. If `encoding` is `'buffer'` (or not a valid Buffer encoding), `Buffer` objects will be passed to
Copy link
Contributor

@cjihrig cjihrig Jun 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments here.

the callback instead.

### child_process.fork(modulePath[, args][, options])
Expand Down