Skip to content

Conversation

@fhinkel
Copy link
Member

@fhinkel fhinkel commented May 27, 2016

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

deps v8

Description of change

Latest set of patch level updates from the V8 5.1 branch.
v8/compare/5.1.281.49...5.1.281.51

This patch brings in @indutny 's fix for tickprocessor Cpp symbols
on mac into V8. So make test is green again on MacOS, specifically for test/parallel/test-tick-processor.js.

/cc @nodejs/v8. This is for the vee-eight-5.1 branch.

This patch brings in @indutny's fix for tickprocessor
Cpp symbols on mac into V8 5.1. So `make test`
is green again on MacOS.
@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label May 27, 2016
@ofrobots
Copy link
Contributor

Note that this partially overlaps with #7016. My suggestion would be hold off until #7016 lands.

@indutny
Copy link
Member

indutny commented May 27, 2016

@ofrobots agree

@fhinkel thank you, though!

@fhinkel
Copy link
Member Author

fhinkel commented May 27, 2016

Ah sorry, I didn't see the other PR. Will wait.

@fhinkel fhinkel closed this May 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants