Skip to content

test: added test for https-agent-getname #6762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
suryagh wants to merge 2 commits into from
Closed

test: added test for https-agent-getname #6762

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f62d843
test: added tests for https-agent-getname
suryagh May 14, 2016
2084001
test: use const and changed port to 443
suryagh May 15, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions test/parallel/test-https-agent-getname.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
'use strict';

require('../common');
var assert = require('assert');
var https = require('https');
Copy link
Member

@jasnell jasnell May 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should use const

Copy link
Contributor Author

@suryagh suryagh May 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


var agent = new https.Agent();

// empty options
assert.strictEqual(
agent.getName({}),
'localhost:::::::::'
);

// pass all options arguments
var options = {
Copy link
Member

@jasnell jasnell May 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be const also

Copy link
Contributor Author

@suryagh suryagh May 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
Also modified the port from 80 to 443, though it makes no difference to the test.

host: '0.0.0.0',
port: 80,
localAddress: '192.168.1.1',
ca: 'ca',
cert: 'cert',
ciphers: 'ciphers',
key: 'key',
pfx: 'pfx',
rejectUnauthorized: false,
servername: 'localhost',
};

assert.strictEqual(
agent.getName(options),
'0.0.0.0:80:192.168.1.1:ca:cert:ciphers:key:pfx:false:localhost'
);