-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
doc: fix style inconsistencies in code examples #6313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
245 commits
Select commit
Hold shift + click to select a range
2dba5da
doc: fix style inconsistencies in code examples
saadq 0c73c9f
src: fix --without-inspector build
addaleax 0e9e149
buffer: fix creating from zero-length ArrayBuffer
RReverser 6626919
inspector: process.exit should wait for inspector
5fd6d75
tools: fix license builder to work with icu-small
e2e615e
stream: reset awaitDrain after manual .resume()
addaleax 08ea9ee
benchmark: add benchmark for url.format()
Trott f1d1071
src: make Sec-WebSocket-Key check case-insensitive
MylesBorins 918159e
http: optimize checkIsHttpToken()
mscdex 83432bf
http: optimize checkInvalidHeaderChar()
mscdex 39fdf07
benchmark: increase http token check iterations
mscdex c8fa79f
test: add more http token/value checking tests
mscdex c570182
benchmark: don't convert arguments to numbers
mscdex 6869846
stream: improve Readable.read() performance
mscdex f914f37
src: clean up string_search
mscdex 1a1ff77
test: fix test-net-* error code check for getaddrinfo(3)
ncopa 357f904
http: fix no dumping after `maybeReadMore`
indutny b5175e8
stream: ensure awaitDrain is increased once
davedoesdev 874839c
doc: add internal link in GOVERNANCE.md
Trott 336b027
url: return valid file: urls fom url.format()
Trott b77eb8c
punycode: update to v2.0.0
mathiasbynens e427150
2016-06-17, Version 6.2.2 (Current) Release
evanlucas 62a858c
doc: fix events typo
greysonp 44b9154
deps: switch to upstream v8_inspector
ofrobots 81b6882
src: rename "node" script to "bootstrap_node"
danbev dfcf02b
inspector: fix coverity scan errors
62c8e7b
doc: fix cluster worker 'message' event
cjihrig 9dfc8b9
inspector: fix inspector connection cleanup
de9a841
doc: fix broken link in vm.md
lpinca 0815b94
vm: add ability to break on sigint/ctrl+c
addaleax dc57b9e
readline: return old status from _setRawMode
addaleax 6a93ab1
repl: break on sigint/ctrl+c
addaleax 740d8cf
doc: add `added:` information for repl
addaleax 3fe3b41
test: add tests for some stream.Readable uses
addaleax a06ccdb
doc: correct `added:` information for fs.access
richardlau a92089b
src: alias BINARY to LATIN1
bnoordhuis 5bddc9a
src: fix Windows segfault with `--eval`
bb33c28
tools: disable readability/function cpplint rule
bnoordhuis d7087df
src: use RAII for mutexes and condition variables
bnoordhuis 781713d
src: remove unused isolate member
bnoordhuis 193afef
doc: document socket.destroyed
tusharmath 6dd093d
buffer,string_decoder: consolidate encoding validation logic
jasnell 58a241d
doc: fix typos in the stream doc
vsemozhetbyt 6be73fe
crypto,tls: perf improvements for crypto and tls getCiphers
jasnell f3d5efa
tls: avoid calling Buffer.byteLength multiple times
jasnell ecc48a1
doc: general improvements to os.md copy
jasnell 92adbe4
doc: add argument information for socket.destroy()
Trott cdcfeb7
test: refresh the tmpdir before using
Trott f34caa9
test: mark test-vm-timeout flaky on windows
Trott efebd0b
doc: add RReverser to collaborators
RReverser a84b0f2
deps: backport 7dfb5beeec from V8 upstream
MylesBorins 86fdbe0
doc: mention http request "aborted" events
kemitchell c2e6078
doc: add `added:` information for tls
44981f2
tools: update certdata.txt
bnoordhuis d02d0b9
tools: output include guards in mk-ca-bundle.pl
bnoordhuis be85e6d
crypto: update root certificates
bnoordhuis ede98a7
test: remove internet/test-tls-connnect-cnnic
bnoordhuis 0a8f5a0
doc: update build instructions for Windows
joaocgreis f3114e2
doc: fix repl defineCommand example
akki 79f961a
doc: fix link in the stream doc
a9c34ae
2016-06-23, Version 4.4.6 'Argon' (LTS)
71b29bb
2016-06-23 Version 0.10.46 (Maintenance) Release
rvagg fb146ce
2016-06-23 Version 0.12.15 (Maintenance) Release
rvagg 6a94383
2016-06-23, Version 5.12.0 (Stable)
evanlucas 5267f29
test: fix flaky test-fs-watch-encoding on OS X
Trott 79ef3b6
string_decoder: fix bad utf8 character handling
mscdex 5e8cbd7
test: add more UTF-8 StringDecoder tests
gagern f5cddad
doc: update "who to cc in issues" chart
Fishrock123 0b9e135
doc: add lance to collaborators
lance c964574
test: add test for exec() known issue
Trott efc3150
test: fix flaky test-vm-timeout
addaleax 61196de
vm: test for abort condition of current invocation
addaleax 1d75987
Revert "test: mark test-vm-timeout flaky on windows"
addaleax 3f5623d
readline: allow passing prompt to constructor
evanlucas 1db31a3
doc: minor rewording to the GitHub issue/pr templates
Fishrock123 d538811
deps: upgrade npm to 3.10.2
iarna a28d373
doc: add CTC meeting minutes 2016-06-15
joshgav 9d56c40
repl: fix tab completion for defined commands
princejwesley 926707f
doc: clarify child_process stdout/stderr types
sartrey 3c09d1b
http: replace finish() callback with arrow function
originalfoo 6abb06f
benchmark: `util._extend` vs `object.assign`
suryagh 97dc38e
doc: fix "sign.verify" typo in crypto doc.
rus0000 4220e86
doc: fix typographic error in process doc
Trott 9744928
doc: fix layout problem in v4 changelog
2787d70
deps: `MASM.UseSafeExceptionHandlers` for OpenSSL
indutny 2996b5c
crypto: Allow GCM ciphers to have a longer IV length
mwain 5615487
src: renaming ares_task struct to node_ares_task
danbev a1059af
buffer: speed up swap16/32, add swap64
zbjornson c0e48bf
repl: Enable tab completion for global properties
lance db21266
assert: remove unneeded arguments special handling
Trott ecd639a
deps: update v8_inspector
targos a77f6eb
inspector: print warning when used
evanlucas 86e07b7
doc: general improvements to timers.md
jasnell fc10624
tools: disable unwanted cpplint rules again
bnoordhuis bb81d69
tools: add back --mode=tap to cpplint
bnoordhuis fadf66a
tools: allow cpplint to run outside git repo
bnoordhuis 19ec5d7
src: fix build/c++tr1 cpplint warnings
bnoordhuis e9559d0
src: fix build/header_guard cpplint warnings
bnoordhuis 29228c4
src: fix readability/braces cpplint warnings
bnoordhuis df3a192
src: fix readability/constructors cpplint warnings
bnoordhuis 8e39522
src: fix readability/inheritance cpplint warnings
bnoordhuis 0ba0eca
src: fix readability/namespace cpplint warnings
bnoordhuis d112df4
src: fix readability/nolint cpplint warnings
bnoordhuis 1243134
src: fix runtime/indentation_namespace warnings
bnoordhuis ae0c650
src: fix runtime/int cpplint warnings
bnoordhuis 2f2002a
src: fix runtime/references cpplint warnings
bnoordhuis 0daffdf
src: fix whitespace/blank_line cpplint warnings
bnoordhuis 97aeb0a
src: fix whitespace/indent cpplint warnings
bnoordhuis f52e26f
build: remove unused files from CPPLINT_FILES
bnoordhuis a26c3cd
src: lint node_win32_perfctr_provider.cc
bnoordhuis f1d2792
src: lint node_lttng_tp.h
bnoordhuis dbe4b58
src: lint v8abbr.h
bnoordhuis 9a6439a
tools: fix -Wunused-variable warning
bnoordhuis f8d3f6f
src: remove obsolete NOLINT comments
bnoordhuis 410296c
build: configure --shared
stefanmb 21535e8
2016-06-28, Version 4.4.7 'Argon' (LTS)
72500f9
doc: add `added:` information for http
addaleax e8356b2
doc: add `added:` information for https
addaleax 010ac70
doc: fix broken refs to url.parse() in http docs
addaleax bbf3838
test: test isFullWidthCodePoint with invalid input
Trott 2cc2951
deps: update V8 to 5.1.281.69
targos b88dee2
deps: cherry-pick 1ef7487b from v8 upstream
mhdawson 35ee1d1
v8: warn in Template::Set() on improper use
bnoordhuis 6dfa533
deps: backport IsValid changes from 4e8736d in V8
targos a33909e
repl: fix repl after V8 upgrade
ofrobots 9940766
test: fix tests after V8 upgrade
ofrobots c938735
dtrace: fix ustack helper for V8 5.1
ofrobots fbfe6c7
build: don't include V8 from node.gyp
targos d894648
deps: revert removal of V8::PromiseEvent
9beef23
deps: bring in V8 5.1 - 5.0 ABI compatibility
04c723d
tools: update cpplint to r456
bnoordhuis 6b0f86a
timers: optimize linkedlist
6f75b66
timers: optimize `setImmediate()`
fba271b
benchmark: add `setImmediate()` benchmarks
5e60ded
src: check uv_async_init() return value
bnoordhuis 88a8748
src: initialize encoding_ data member
bnoordhuis 57387fa
src: guard against starting fs watcher twice
bnoordhuis 664ba51
src: remove unused data member write_queue_size_
bnoordhuis 0e82069
src: remove unused md_ data members
bnoordhuis d404566
src: remove duplicate HMAC_Init calls
bnoordhuis 26a918f
src: remove deprecated HMAC_Init, use HMAC_Init_ex
bnoordhuis da4c1c3
src: fix use-after-return in zlib bindings
bnoordhuis c50e192
src: fix memory leak in WriteBuffers() error path
bnoordhuis ed3d8b1
src: fix bad logic in uid/gid checks
bnoordhuis 5251fe5
test: add testcfg.py to test/abort/
bnoordhuis 0672fca
test: fix abort/test-abort-uncaught-exception
bnoordhuis 3c85f4e
test: don't use internal headers in add-on tests
bnoordhuis 787eddf
src: print backtrace on fatal error
bnoordhuis e574f5b
src: print backtrace on abort/unreachable code
bnoordhuis 64edd06
test: add abort test for backtrace validation
cjihrig be767cf
src: move ABORT() logic into node::Abort()
bnoordhuis 92dab4a
src: print backtrace on failed CHECK/ASSERT
bnoordhuis dac16d8
test: check types for http request and response
bnoordhuis cae428a
tools: explicit path for V8 test tap output
08aff14
inspector: Do cleanups before notifying callback
3d6a01e
deps: update icu-small to include punycode datafiles
jasnell 7de59ef
net: use icu's punycode implementation
jasnell 02afb05
doc: fixing minor typo in AtExit hooks section
danbev 3cac616
vm: don't print out arrow message for custom error
addaleax 7dcc4af
build: drop unconditional openssl dep from cctest
bnoordhuis c5c28c3
debugger: make listen address configurable
bnoordhuis 5e5ec2c
os: deprecate `tmpDir()` in favour of `tmpdir()`
Fishrock123 dc17432
deps: fix V8 5.1 tests
targos 15157c3
repl: Default `useGlobal` to false in CLI REPL.
lance 8da541b
Revert "child_process: measure buffer length in bytes"
Trott 0268fd0
child_process: preserve argument type
Trott 0548e5d
child_process: add fork/execFile arg validation
Trott 99cfd53
test: test execFile/fork arg validation
ChuckLangford 42de4bb
doc: improve usage of `zero`/`0`
Trott abce60c
test: remove common.PORT from http tests
Trott 1299c27
doc: add guide for Node.js Timers
ryanmurakami 7cbbec5
build: split CI rules in Makefile
joaocgreis fb4c022
test: handle SmartOS bug in test-tls-session-cache
Trott b3ec243
deps: upgrade npm to 3.10.3
zkat f47c394
test: listen on and connect to 127.0.0.1
bnoordhuis 475dc43
doc: fix documentation of process.argv
tarungarg546 d80432d
build: enable big toc for release builds in AIX
gireeshpunathil b4d4fd9
build: export openssl symbols on windows
bnoordhuis a2ee21d
util: add an option for configuring break length
cjihrig cd4dbf3
doc: add `added:` information for timers
addaleax 95a3c8f
build: Fix compile failure in backtrace_posix.cc
mhdawson 1fe0708
test: really run addon tests on `make test`
addaleax af273b5
test: skip doctool tests when js-yaml is missing
addaleax 6ae2043
src: move ParseArrayIndex() to src/node_buffer.cc
bnoordhuis 630096b
src: guard against overflow in ParseArrayIndex()
bnoordhuis 5a571a5
doc: fix detached child stdio example
cjihrig 7628031
2016-07-06, Version 6.3.0 (Current)
Fishrock123 6ee9e29
doc: add bartosz sosnowski to colaborators
bzoz b10ee9d
doc: updating REPLACEME tag during release
gibfahn 0f3149e
doc: fix minor style issues in http.md
Trott 4c774e1
deps: remove extra field from v8::HeapStatistics
addaleax 9d654a3
test: fix flaky test-net-write-slow
Trott c8eb62f
test: remove unused var from stream2 test
Trott 24ee0d2
test: remove unused var in net-server-try-ports
Trott 3ae4377
net: export isIPv4, isIPv6 directly from cares
thefourtheye 89ede72
tools: remove unnecessary imports and assignments
thefourtheye 18ae74c
src: suppress coverity message
cjihrig 9fbe456
repl: add support for custom completions
diosney b9b49ee
test: fix flaky test-fs-read-buffer-tostring-fail
Trott 245ac30
deps: update V8 to 5.1.281.75
bnoordhuis 990c968
build: respect --shared-* flags for inspector deps
ChALkeR 0a9f27b
build: add --enable-d8 configure option
bnoordhuis 69ef9b1
build: add v8 requirement to test-v8* in Makefile
targos 22492db
build: use BUILDTYPE when building V8 in Makefile
targos 5a641e2
doc,dgram: fix addMembership documentation
santigimeno fa46e50
doc: added information on how to run the linter.
diosney e44b438
tools: remove unused variable
Trott 2bd8942
test: remove unused var in test-tls-server-verify
Trott bc5b89f
test: remove unused vars from http/https tests
Trott 7b0cf87
test: remove unused var from child-process-fork
Trott ce9456d
benchmark: remove unused variables
Trott a528d0d
doc: add benchmark who-to-CC info
Trott 46f40cf
buffer: fix unintended unsigned overflow
indutny c9f6776
crypto: fix undefined behavior in ParseExtension
indutny 839f3d9
deps: cherry-pick d721121 from v8 upstream
bnoordhuis f3a3888
test: move parallel/test-tty-* to pseudo-tty/
Fishrock123 aab3066
test: fix old tty tests
Fishrock123 fcae5e2
doc: dns.resolve fix callback argument description
qheaden e8a7003
tools: update ESLint, fix unused vars bug
Trott cfe76f2
src: disable stdio buffering
bnoordhuis 2d77cba
test: fix flaky test-*-connect-address-family
Trott 780776c
tools: cleanup no-build and build-only options
thefourtheye ef1f766
tools: fix broken format string
thefourtheye 55250b8
doc: grammar fixes to event loop guide
ryanmurakami 5b63d48
lib,benchmark,test: implement consistent braces
Trott 863952e
tools: enforce JS brace style with linting
Trott b8b8c36
build: export more openssl symbols on Windows
4b9a0e4
doc: link and highlight Object.assign
thefourtheye bc7b719
doc: fix util.deprecate() example
evanlucas c01d61a
win,msi: Added Italian translation
mcollina a2a711a
dgram: generalized send queue to handle close
mcollina cbbddc4
tools: increase lint coverage
Trott a7105a8
test,doc: clarify `buf.indexOf(num)` input range
addaleax 80478a5
doc: fix typo in the CHANGELOG_V6
vsemozhetbyt 11b2306
tools: consistent .eslintrc formatting
silverwind e09c62a
win,msi: add zh-CN translations for the installer
pmq20 a58b48b
doc: various documentation formatting fixes
ChALkeR e9bb332
test: add common.rootDir
cjihrig 6e15ae9
fs: rename event to eventType in fs.watch listener
claudiorodriguez 4220c24
inspector: Unify event queues
4a40832
test: cleanup IIFE tests
cjihrig d11f475
test: improve error message in test-tick-processor
Trott 89763bb
doc: fix style inconsistencies in code examples
saadq 19d8604
Merge branch 'master' of github.com:saadq/node
saadq 79fe070
Add missing semicolon
saadq File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a
;here too (L1188).