tools: fix update-nghttp2 signature verification #61035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detached signatures must be passed to `gpgv` as a filename before the datafile (which can be stdin but the detached signature file cannot be stdin and cannot be piped in).
Collaborator
|
Review requested:
|
targos
approved these changes
Dec 12, 2025
marco-ippolito
approved these changes
Dec 12, 2025
richardlau
added
author ready
cjihrig
approved these changes
Dec 12, 2025
lpinca
approved these changes
Dec 12, 2025
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 05f8772 |
aduh95
pushed a commit
that referenced
this pull request
Jan 9, 2026
Detached signatures must be passed to `gpgv` as a filename before the datafile (which can be stdin but the detached signature file cannot be stdin and cannot be piped in). PR-URL: #61035 Refs: #60113 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jan 12, 2026
Detached signatures must be passed to `gpgv` as a filename before the datafile (which can be stdin but the detached signature file cannot be stdin and cannot be piped in). PR-URL: #61035 Refs: #60113 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 13, 2026
Detached signatures must be passed to `gpgv` as a filename before the datafile (which can be stdin but the detached signature file cannot be stdin and cannot be piped in). PR-URL: #61035 Refs: #60113 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detached signatures must be passed to
gpgvas a filename before the datafile (which can be stdin but the detached signature file cannot be stdin and cannot be piped in).Refs: #60113
The nghttp2 updater has been failing since #60113.
e.g. https://github.com/nodejs/node/actions/runs/19996542494/job/57344965958#step:6:11