-
-
Notifications
You must be signed in to change notification settings - Fork 34.4k
util: process signal to exit code utility #60963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 7 commits into
nodejs:main
from
ErickWendel:erickwendel/add-convert-process-signal-to-exit-code
Dec 11, 2025
Merged
util: process signal to exit code utility #60963
nodejs-github-bot
merged 7 commits into
nodejs:main
from
ErickWendel:erickwendel/add-convert-process-signal-to-exit-code
Dec 11, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add convertProcessSignalToExitCode() to convert signal names to POSIX exit codes (128 + signal number). Exposed in public util API. Refs: nodejs#60720
Document util.convertProcessSignalToExitCode() in child_process module to help users convert signal names to POSIX exit codes when a child process is terminated by a signal. Refs: nodejs#60285
RafaelGSS
reviewed
Dec 5, 2025
addaleax
reviewed
Dec 5, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60963 +/- ##
==========================================
- Coverage 88.53% 88.51% -0.03%
==========================================
Files 703 703
Lines 208413 208512 +99
Branches 40191 40215 +24
==========================================
+ Hits 184521 184565 +44
- Misses 15902 15963 +61
+ Partials 7990 7984 -6
🚀 New features to boost your workflow:
|
addaleax
approved these changes
Dec 9, 2025
Collaborator
RafaelGSS
approved these changes
Dec 9, 2025
Contributor
|
Seemingly related failure on Windows: |
Collaborator
Member
Author
This was due I fogot to use the constants.signals in the test. Now it should pass, |
Collaborator
Collaborator
Collaborator
MoLow
approved these changes
Dec 11, 2025
Collaborator
|
Landed in e705603 |
aduh95
pushed a commit
that referenced
this pull request
Jan 9, 2026
Add convertProcessSignalToExitCode() to convert signal names to POSIX exit codes (128 + signal number). Exposed in public util API. Refs: #60720 PR-URL: #60963 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jan 12, 2026
Add convertProcessSignalToExitCode() to convert signal names to POSIX exit codes (128 + signal number). Exposed in public util API. Refs: #60720 PR-URL: #60963 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 13, 2026
Add convertProcessSignalToExitCode() to convert signal names to POSIX exit codes (128 + signal number). Exposed in public util API. Refs: #60720 PR-URL: #60963 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
nodejs-github-bot
added a commit
that referenced
this pull request
Jan 16, 2026
Notable changes: cli: * add --require-module/--no-require-module (Joyee Cheung) #60959 * mark --heapsnapshot-near-heap-limit as stable (Joyee Cheung) #60956 crypto: * update root certificates to NSS 3.117 (Node.js GitHub Bot) #60741 doc: * add @avivkeller to collaborators (Aviv Keller) #61115 * add gurgunday to collaborators (Gürgün Dayıoğlu) #61094 * mark --build-snapshot and --build-snapshot-config as stable (Joyee Cheung) #60954 events: * (SEMVER-MINOR) repurpose `events.listenerCount()` to accept EventTargets (René) #60214 http: * (SEMVER-MINOR) add http.setGlobalProxyFromEnv() (Joyee Cheung) #60953 meta: * add Renegade334 to collaborators (Renegade334) #60714 module: * mark require(esm) as stable (Joyee Cheung) #60959 * mark module compile cache as stable (Joyee Cheung) #60971 * (SEMVER-MINOR) allow subpath imports that start with `#/` (Jan Martin) #60864 process: * (SEMVER-MINOR) preserve AsyncLocalStorage in queueMicrotask only when needed (Gürgün Dayıoğlu) #60913 stream: * (SEMVER-MINOR) do not pass `readable.compose()` output via `Readable.from()` (René) #60907 util: * (SEMVER-MINOR) add convertProcessSignalToExitCode utility (Erick Wendel) #60963 v8: * mark v8.queryObjects() as stable (Joyee Cheung) #60957 PR-URL: #61400
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
needs-ci
PRs that need a full CI run.
semver-minor
PRs that contain new features and should be released in the next minor version.
util
Issues and PRs related to the built-in util module.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
util.convertProcessSignalToExitCode()utility function to convert signal names (e.g.,SIGTERM,SIGKILL) to their corresponding POSIX exit codes.When a child process is terminated by a signal, the
codeparameter in the'exit'and'close'events isnull. This utility allows users to convert thesignalparameter to the POSIX standard exit code.Example
Note: While Windows doesn't natively support POSIX signals, Node.js provides a cross-platform abstraction that emulates signal behavior. This allows
convertProcessSignalToExitCode()to work consistently across all platforms, returning the same POSIX exit codes on both Unix-like systems and Windows.Refs