Skip to content

Conversation

@Han5991
Copy link
Contributor

@Han5991 Han5991 commented Nov 10, 2025

Summary

  • In test/addons/cppgc-object/test.js, force each gcUntil() loop to request a major GC
    ({ type: 'major', execution: 'beforeUserJS' }). This increases the likelihood that old
    CppGCed wrappers are collected promptly.

  • The test logic remains the same; it just invokes a stronger GC flavor to avoid the CI
    flake where “All old CppGCed are destroyed” never becomes true within 10 attempts.

  • https://github.com/nodejs/node/actions/runs/19245913659/job/55019892774?pr=60665

    Testing

    • make build-addons
    • python3 tools/test.py addons/cppgc-object/test

@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 10, 2025
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (4f1ab8c) to head (e0cd646).
⚠️ Report is 56 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60672      +/-   ##
==========================================
+ Coverage   88.03%   88.55%   +0.52%     
==========================================
  Files         703      703              
  Lines      208257   208257              
  Branches    40069    40156      +87     
==========================================
+ Hits       183336   184420    +1084     
+ Misses      16883    15866    -1017     
+ Partials     8038     7971      -67     

see 104 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 18, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 18, 2025
@nodejs-github-bot
Copy link
Collaborator

@Han5991
Copy link
Contributor Author

Han5991 commented Nov 18, 2025

@legendecas

Hi, this CI failure looks unrelated to the changes in this PR and seems to be caused by a flaky test.
Could you re-run only the failed CI jobs when you get a chance?

Thanks!

@nodejs-github-bot
Copy link
Collaborator

@Han5991
Copy link
Contributor Author

Han5991 commented Nov 24, 2025

@legendecas Hi! I've addressed your review feedback in the latest commits. The PR now has two approvals and CI is green. Would you mind taking another look when you get a chance? Thanks!

@legendecas legendecas added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Nov 24, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 24, 2025
@nodejs-github-bot nodejs-github-bot merged commit b011cc5 into nodejs:main Nov 24, 2025
74 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in b011cc5

targos pushed a commit that referenced this pull request Nov 27, 2025
PR-URL: #60672
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addons Issues and PRs related to native addons. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants