-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
test: prefer major GC in cppgc-object #60672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60672 +/- ##
==========================================
+ Coverage 88.03% 88.55% +0.52%
==========================================
Files 703 703
Lines 208257 208257
Branches 40069 40156 +87
==========================================
+ Hits 183336 184420 +1084
+ Misses 16883 15866 -1017
+ Partials 8038 7971 -67 🚀 New features to boost your workflow:
|
24f8a74 to
e0cd646
Compare
|
Hi, this CI failure looks unrelated to the changes in this PR and seems to be caused by a flaky test. Thanks! |
|
@legendecas Hi! I've addressed your review feedback in the latest commits. The PR now has two approvals and CI is green. Would you mind taking another look when you get a chance? Thanks! |
|
Landed in b011cc5 |
PR-URL: #60672 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Summary
In
test/addons/cppgc-object/test.js, force eachgcUntil()loop to request a major GC(
{ type: 'major', execution: 'beforeUserJS' }). This increases the likelihood that oldCppGCed wrappers are collected promptly.
The test logic remains the same; it just invokes a stronger GC flavor to avoid the CI
flake where “All old CppGCed are destroyed” never becomes true within 10 attempts.
https://github.com/nodejs/node/actions/runs/19245913659/job/55019892774?pr=60665
Testing