-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
crypto: ensure documented RSA-PSS saltLength default is used #60662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
panva
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
panva:ensure-rsa-pss-salt-length-default
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+44
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
tniessen
approved these changes
Nov 10, 2025
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60662 +/- ##
==========================================
- Coverage 88.55% 88.53% -0.02%
==========================================
Files 703 703
Lines 208077 208083 +6
Branches 40083 40081 -2
==========================================
- Hits 184254 184235 -19
- Misses 15841 15878 +37
+ Partials 7982 7970 -12
🚀 New features to boost your workflow:
|
Collaborator
aduh95
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue
Add this label to land a pull request using GitHub Actions.
confirmed-bug
Issues with confirmed bugs.
crypto
Issues and PRs related to the crypto subsystem.
lts-watch-v20.x
PRs that may need to be released in v20.x
lts-watch-v22.x
PRs that may need to be released in v22.x
lts-watch-v24.x
PRs that may need to be released in v24.x
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the documented RSA-PSS saltLength default is used regardless of the OpenSSL version used by the runtime.