crypto: better error message when calling digest twice on a hash #6042

calvinmetcalf · 2016-04-04T19:42:05Z

Pull Request check-list

Please make sure to review and check all of these items:

Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
this change (including linting)?

I'm getting an error on the test-tick-processor test, seems unrelated

Is the commit message formatted according to CONTRIBUTING.md?
If this change fixes a bug (or a performance problem), is a regression
test (or a benchmark) included?
Is a documentation update included (if this change modifies
existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Affected core subsystem(s)

Please provide affected core subsystem(s) (like buffer, cluster, crypto, etc)

Description of change

calling digest twice on a hash used to give an unhelpful error about the hash not being initialized, this fixes that

fanatid · 2016-04-04T19:49:36Z

It would be nice to have same for Hmac.
BTW, right now second call hmac.digest don't throwing error, but docs says that it should: https://nodejs.org/api/crypto.html#crypto_hmac_digest_encoding (Multiple calls to hmac.digest() will result in an error being thrown.)

calvinmetcalf · 2016-04-04T19:52:23Z

I'd probably want to put that into a different pull request

mscdex · 2016-04-04T19:57:36Z

src/node_crypto.cc

I think the spaces before and after the arrow should be removed.

mscdex · 2016-04-04T19:59:24Z

Perhaps we should also be inserting a similar check for .update()?

addaleax · 2016-04-04T20:04:01Z

src/node_crypto.cc

Any particular reason for the capitalization here?

good point fixing

fanatid · 2016-04-04T20:25:58Z

why not use only finalized_? (in .update() and .digest())
I don't see sense in initialised_ because Hash can't be refreshed

calvinmetcalf · 2016-04-05T11:26:25Z

@fanatid because there could be some way that a bug could cause the hash to be in an inconsistent state and better safe then sorry

fanatid · 2016-04-05T11:42:07Z

@calvinmetcalf I think that this line never will be reached because you add error throwing
I don't see how initialised_ can be set to false since you've added finalized_

calvinmetcalf · 2016-04-05T11:48:55Z

@fanatid if this line was never reached

mscdex · 2016-04-05T11:49:18Z

test/parallel/test-crypto-hash.js

Capitalization should be changed here too.

mscdex · 2016-04-05T11:50:21Z

I think an additional test for .update() should be added for completeness. Other than that it LGTM if CI is ok with it.

jasnell · 2016-04-05T13:31:47Z

LGTM pending CI

mscdex · 2016-04-05T13:34:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/2159/

fanatid · 2016-04-06T04:58:09Z

@calvinmetcalf could you answer for my first question?

this line never will be reached because you add error throwing

mscdex · 2016-04-06T05:05:52Z

test/parallel/test-crypto-hash.js

Linter is complaining about trailing spaces on this line

calvinmetcalf · 2016-04-06T12:12:58Z

@fanatid woops was cut off replying via email, the initialized would only ever be false if for some reason the hash wasn't initialized, which probably not be possible as it is currently set up, but we don't really loose much testing for it and we will prevent problems down the line if some other change allows it to get into a weird state.

calling digest or update on a hash object after digest has been called now gives a topical error message instead of an error message saying that the hash failed to initialize.

jasnell · 2016-04-12T04:40:13Z

@mscdex ... ping.. looks like this was updated. PTAL

mscdex · 2016-04-12T04:45:20Z

CI again: https://ci.nodejs.org/job/node-test-pull-request/2245/

jasnell · 2016-04-12T05:49:08Z

CI is green

mscdex · 2016-04-12T13:07:44Z

LGTM

calling digest or update on a hash object after digest has been called now gives a topical error message instead of an error message saying that the hash failed to initialize. PR-URL: #6042 Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>

jasnell · 2016-04-18T23:01:36Z

Landed in 1d9451b

calling digest or update on a hash object after digest has been called now gives a topical error message instead of an error message saying that the hash failed to initialize. PR-URL: nodejs#6042 Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>

calling digest or update on a hash object after digest has been called now gives a topical error message instead of an error message saying that the hash failed to initialize. PR-URL: #6042 Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>

calvinmetcalf changed the title ~~[crypto] better error message when calling digest twice on a hash~~ crypto: better error message when calling digest twice on a hash Apr 4, 2016

calvinmetcalf mentioned this pull request Apr 4, 2016

extract md5 browserify/createHash#11

Closed

mscdex reviewed Apr 4, 2016
View reviewed changes

mscdex added crypto Issues and PRs related to the crypto subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. labels Apr 4, 2016

calvinmetcalf force-pushed the digest-error-msg branch from d3f1fea to 735ac30 Compare April 4, 2016 20:00

addaleax reviewed Apr 4, 2016
View reviewed changes

jasnell added semver-major PRs that contain breaking changes and should be released in the next major version. error-handling labels Apr 4, 2016

calvinmetcalf force-pushed the digest-error-msg branch 2 times, most recently from 3b61487 to ba02203 Compare April 5, 2016 11:25

mscdex reviewed Apr 5, 2016
View reviewed changes

test/parallel/test-crypto-hash.js Outdated

Copy link

Contributor

mscdex Apr 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalization should be changed here too.

calvinmetcalf force-pushed the digest-error-msg branch 3 times, most recently from 3cda16d to 4d5a452 Compare April 5, 2016 12:49

mscdex reviewed Apr 6, 2016
View reviewed changes

test/parallel/test-crypto-hash.js Outdated

Copy link

Contributor

mscdex Apr 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter is complaining about trailing spaces on this line

crypto: better error message for createHash

2cb82d2

calling digest or update on a hash object after digest has been called now gives a topical error message instead of an error message saying that the hash failed to initialize.

calvinmetcalf force-pushed the digest-error-msg branch from 4d5a452 to 2cb82d2 Compare April 6, 2016 12:13

jasnell closed this Apr 18, 2016

Uh oh!

crypto: better error message when calling digest twice on a hash #6042

crypto: better error message when calling digest twice on a hash #6042

Uh oh!

Conversation

calvinmetcalf commented Apr 4, 2016

Pull Request check-list

Affected core subsystem(s)

Description of change

Uh oh!

fanatid commented Apr 4, 2016

Uh oh!

calvinmetcalf commented Apr 4, 2016

Uh oh!

mscdex Apr 4, 2016

Choose a reason for hiding this comment

Uh oh!

calvinmetcalf Apr 4, 2016

Choose a reason for hiding this comment

Uh oh!

mscdex commented Apr 4, 2016

Uh oh!

addaleax Apr 4, 2016

Choose a reason for hiding this comment

Uh oh!

calvinmetcalf Apr 5, 2016

Choose a reason for hiding this comment

Uh oh!

fanatid commented Apr 4, 2016

Uh oh!

calvinmetcalf commented Apr 5, 2016

Uh oh!

fanatid commented Apr 5, 2016

Uh oh!

calvinmetcalf commented Apr 5, 2016

Uh oh!

mscdex Apr 5, 2016

Choose a reason for hiding this comment

Uh oh!

mscdex commented Apr 5, 2016

Uh oh!

jasnell commented Apr 5, 2016

Uh oh!

mscdex commented Apr 5, 2016

Uh oh!

fanatid commented Apr 6, 2016

Uh oh!

mscdex Apr 6, 2016

Choose a reason for hiding this comment

Uh oh!

calvinmetcalf commented Apr 6, 2016

Uh oh!

jasnell commented Apr 12, 2016

Uh oh!

mscdex commented Apr 12, 2016

Uh oh!

jasnell commented Apr 12, 2016

Uh oh!

mscdex commented Apr 12, 2016

Uh oh!

jasnell commented Apr 18, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants