-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
Fix RSA-OAEP encryption for empty strings #57558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
AmitPrajapati-1
wants to merge
4
commits into
nodejs:main
from
AmitPrajapati-1:fix-crypto-private-decrypt
Closed
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4eb99a4
Fix RSA-OAEP encryption for empty strings
AmitPrajapati-1 756185d
Fix lint errors and add hasCrypto check in test-crypto-private-decryp…
AmitPrajapati-1 0791374
fix empty string bug
AmitPrajapati-1 888d1a3
Merge branch 'nodejs:main' into fix-crypto-private-decrypt
AmitPrajapati-1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| 'use strict'; | ||
|
|
||
| const common = require('../common'); | ||
| const crypto = require('crypto'); | ||
|
|
||
| if (!common.hasCrypto) { | ||
| common.skip('missing crypto'); | ||
| } | ||
|
|
||
| const keys = crypto.generateKeyPairSync('rsa', { | ||
| modulusLength: 2048, | ||
| publicKeyEncoding: { type: 'spki', format: 'pem' }, | ||
| privateKeyEncoding: { type: 'pkcs8', format: 'pem' } | ||
| }); | ||
|
|
||
| const empty = ''; | ||
|
|
||
| const ciphertext = crypto.publicEncrypt({ | ||
| oaepHash: 'sha1', | ||
| padding: crypto.constants.RSA_PKCS1_OAEP_PADDING, | ||
| key: keys.publicKey | ||
| }, Buffer.from(empty)).toString('base64'); | ||
|
|
||
| const plaintext = crypto.privateDecrypt({ | ||
| oaepHash: 'sha1', | ||
| padding: crypto.constants.RSA_PKCS1_OAEP_PADDING, | ||
| key: keys.privateKey | ||
| }, Buffer.from(ciphertext, 'base64')).toString('utf8').trim(); | ||
|
|
||
| console.log('Decrypt', plaintext); | ||
| console.assert(empty === plaintext, 'rsa-oaep `encrypt` empty string is success, but `decrypt` got unexpected string.'); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the last
trim()function maynot a good idea. In my opinion, the fix should be in the internalClevel.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed encryption and decryption logic for improved accuracy and consistency.