Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions GOVERNANCE.md
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,27 @@ Collaborators might overlook someone with valuable contributions. In that case,
the contributor may open an issue or contact a collaborator to request a
nomination.

#### How to review a collaborator nomination

A collaborator nomination can be reviewed in the same way you'd review a PR
Copy link
Member

@joyeecheung joyeecheung Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's specifically how PRs should be reviewed but I think a practice that many do in the case of doubts (because we don't always use the red X to express concerns) is:

  • explicitly ask: are your comments blocking?
  • announce with a deadline: if there are no more comments by (some time) I will proceed landing it.

Which I think can also be used in this case to prevent awkward situations from happening, since we are just giving suggestions about how to prevent awkward situations :)

adding a feature:

- If you see the nomination as something positive to the project, say so!
- If you are neutral, or feel you don't know enough to have an informed opinion,
it's certainly OK to not interact with the nomination.
- If you think the nomination can be detrimental to the project, share your
concerns, ideally before the public nomination is opened, and avoid sharing
those concerns outside of the Collaborator discussion area.
Ideally, list what step(s) the nominee could take that would make you
approve their nomination.

Our goal is to keep gate-keeping at a minimal, but it cannot be zero since being
a collaborator requires trust (collaborators can start CI jobs, use their veto,
push commits, etc.), so what's the minimal amount is subjective, and there will
be cases where collaborators disagree on whether a nomination should move
forward. In those case, refrain from opening the public nomination until all
concerns have been addressed.

### Onboarding

After the nomination passes, a TSC member onboards the new collaborator. See
Expand Down
Loading