util: inspect: avoid a crash on a DataView with a detached buffer #56669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
force-pushed
the
detached-data-view
branch
from
76816c0 to
6c20156
Compare
anonrig
reviewed
Jan 20, 2025
ljharb
force-pushed
the
detached-data-view
branch
from
6c20156 to
3b2895d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #56669 +/- ##
==========================================
- Coverage 89.21% 89.21% -0.01%
==========================================
Files 662 662
Lines 191893 191914 +21
Branches 36936 36941 +5
==========================================
+ Hits 171189 171207 +18
- Misses 13541 13549 +8
+ Partials 7163 7158 -5
🚀 New features to boost your workflow:
|
ljharb
added
request-ci
BridgeAR
requested changes
Jan 21, 2025
Member
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
The current approach would impact the common case, while it's possible to separate that to only being treated special in case a DataView is handled.
@ljharb please have a look at the detached ArrayBuffer implementation handling. That works without impacting the common case :)
Member
|
Ping @ljharb |
Member
Author
|
thanks, still on my list :-) will try to get to it soon |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Oct 6, 2025
This makes sure special properties (such as a byteLength, buffer, and more) are marked that they are not regular properties. They are mostly getters, that just seemed even more of a breaking change. Thus, they just use square brackets for now. On top of that, it makes inspecting detached DataViews robust. Inspecting those failed so far. Closes: nodejs#56669
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Oct 6, 2025
This makes sure special properties (such as a byteLength, buffer, and more) are marked that they are not regular properties. They are mostly getters, that just seemed even more of a breaking change. Thus, they just use square brackets for now. On top of that, it makes inspecting detached DataViews robust. Inspecting those failed so far. Closes: nodejs#56669
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.