Skip to content

doc: fix setter of event.cancelBubble #45986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 4 commits into from
Jan 7, 2023
Merged

doc: fix setter of event.cancelBubble #45986

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9dd8e84
doc: fix setter of `event.cancelBubble`
deokjinkim Dec 27, 2022
e320789
Apply suggestions from code review
deokjinkim Dec 28, 2022
8f78b2e
Add missed `Type:` to specify data type
deokjinkim Dec 28, 2022
31f921e
Revert change of JSDoc
deokjinkim Dec 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions doc/api/events.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1748,14 +1748,16 @@ added: v14.5.0

This is not used in Node.js and is provided purely for completeness.

#### `event.cancelBubble()`
#### `event.cancelBubble`

<!-- YAML
added: v14.5.0
-->

Alias for `event.stopPropagation()`. This is not used in Node.js and is
provided purely for completeness.
* Type: {boolean}

Alias for `event.stopPropagation()` if set to `true`. This is not used
in Node.js and is provided purely for completeness.

#### `event.cancelable`

Expand Down
2 changes: 1 addition & 1 deletion lib/internal/event_target.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ class Event {
}

/**
* @type {boolean}
* @param {boolean} value
*/
set cancelBubble(value) {
if (!isEvent(this))
Expand Down