Skip to content

fix: Blob constructor on various ArrayBuffer views #40706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 8 commits into from
Dec 10, 2021
Merged

fix: Blob constructor on various ArrayBuffer views #40706

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5a85bc3
fix: Blob constructor on various ArrayBuffer views
Gozala Nov 2, 2021
cf3abfd
fix: only copy necessary bytes
Gozala Nov 2, 2021
ccc06b7
chore: add test case
Gozala Nov 2, 2021
bcab31e
fix: slice buffer from both sides
Gozala Nov 3, 2021
95ca174
Update test/parallel/test-blob.js
Gozala Nov 3, 2021
42f3f74
fix: address lint & test errors
Gozala Nov 3, 2021
9791e08
fix: lint error at test/parallel/test-blob.js
Gozala Nov 3, 2021
df6ad22
chore: fix test failures for big endian hosts
Gozala Nov 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/internal/blob.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ function getSource(source, endings) {
// BackingStores are going to be detached and owned by
// the Blob. We also don't want to have to worry about
// byte offsets.
source = new Uint8Array(source);
source = new Uint8Array(source.buffer.slice(0), source.byteOffset);
return [source.byteLength, source];
}

Expand Down