[v14.x backport] lib: revert primordials in a hot path#38972

Closed

aduh95 wants to merge 250 commits intonodejs:v14.x-stagingfrom

aduh95:revert-primordials-v14.x

Commits on May 16, 2021

tools: add new ESLint rule: prefer-primordials
targos
committed
tools,lib: tighten prefer-primordials rules for Error statics

aduh95
authored and
targos
committed
tools,lib: recommend using safe primordials

aduh95
authored and
targos
committed
timers: cleanup abort listener on awaitable timers
targos
committed
lib: add %TypedArray% abstract constructor to primordials

ExE-Boss
authored and
targos
committed
module: refactor to use more primordials

aduh95
authored and
targos
committed
tools: update ESLint to 7.11.0

cjihrig
authored and
targos
committed
tools: update ESLint to 7.12.0

cjihrig
authored and
targos
committed
tools: update ESLint to 7.12.1

cjihrig
authored and
targos
committed
tools: update ESLint to 7.13.0

lpinca
authored and
targos
committed
test: use `.then(common.mustCall())` for all async IIFEs

addaleax
authored and
targos
committed
tools: add linting rule for async IIFEs

addaleax
authored and
targos
committed
test: add Actions annotation output

mmarchini
authored and
targos
committed
stream: fix legacy pipe error handling

ronag
authored and
targos
committed
doc: document changes for `*/promises` alias modules

ExE-Boss
authored and
targos
committed
child_process: refactor to use more primordials

aduh95
authored and
targos
committed
lib,tools: enforce access to prototype from primordials

aduh95
authored and
targos
committed
timers: refactor to use more primordials
targos
committed
http2: add support for TypedArray to getUnpackedSettings

aduh95
authored and
targos
committed
lib: refactor to use more primordials

aduh95
authored and
targos
committed
errors: refactor to use more primordials

aduh95
authored and
targos
committed
src: fix label indentation

Trott
authored and
targos
committed
tools: update ESLint to 7.14.0

cjihrig
authored and
targos
committed
tools: enable no-nonoctal-decimal-escape lint rule

cjihrig
authored and
targos
committed
lib: refactor primordials.uncurryThis

aduh95
authored and
targos
committed
deps: V8: cherry-pick 86991d0587a1

Benjamin Coe
authored and
targos
committed
policy: refactor to use more primordials

aduh95
authored and
targos
committed
tty: refactor to use more primordials

Lxxyx
authored and
targos
committed
os: refactor to use more primordials

aduh95
authored and
targos
committed
v8: refactor to use more primordials

aduh95
authored and
targos
committed
perf_hooks: refactor to use more primordials

aduh95
authored and
targos
committed
errors: display original symbol name

bcoe
authored and
targos
committed
buffer: refactor to use more primordials

aduh95
authored and
targos
committed
timers: reject with AbortError on cancellation
targos
committed
worker: refactor to use more primordials

aduh95
authored and
targos
committed
path: refactor to use more primordials

aduh95
authored and
targos
committed
src: use transferred consistently

danbev
authored and
targos
committed
querystring: refactor to use more primordials

aduh95
authored and
targos
committed
module: refactor to use more primordials

aduh95
authored and
targos
committed
zlib: refactor to use more primordials

aduh95
authored and
targos
committed
dgram: refactor to use more primordials

aduh95
authored and
targos
committed
readline: refactor to use more primordials

aduh95
authored and
targos
committed
buffer: refactor to use primordials instead of Array#reduce

aduh95
authored and
targos
committed
string_decoder: refactor to use more primordials

aduh95
authored and
targos
committed
lib: add uncurried accessor properties to `primordials`

ExE-Boss
authored and
targos
committed
net: refactor to use more primordials

aduh95
authored and
targos
committed
tools: enable no-unused-expressions lint rule
targos
committed
dns: refactor to use more primordials

aduh95
authored and
targos
committed
doc: document ABORT_ERR code

benjamingr
authored and
targos
committed
tools: update ESLint to 7.15.0

cjihrig
authored and
targos
committed
tools: enable no-unsafe-optional-chaining lint rule

cjihrig
authored and
targos
committed
inspector: refactor to use more primordials

aduh95
authored and
targos
committed
util: simplify constructor retrieval in inspect()

Trott
authored and
targos
committed
build: fix make test-npm

ruyadorno
authored and
targos
committed
tools: update ESLint to 7.16.0

zhangyongsheng
authored and
targos
committed
tools: update ESLint to 7.17.0

cjihrig
authored and
targos
committed
lib: refactor to use more primordials in internal/histogram.js

authored and
targos
committed
v8: refactor to use more primordials

aduh95
authored and
targos
committed
doc: expand openssl instructions

mhdawson
authored and
targos
committed
deps: V8: cherry-pick dfcdf7837e23

Benjamin Coe
authored and
targos
committed
events: refactor to use more primordials

aduh95
authored and
targos
committed

Commits on May 18, 2021

Commits on May 25, 2021

src: add check against non-weak BaseObjects at process exit

addaleax
authored and
targos
committed
src: fix compiler warning in env.cc

addaleax
authored and
targos
committed

Commits on Jun 5, 2021

src: fix compiler warnings in node_buffer.cc

RaisinTen
authored and
targos
committed
lib: make safe primordials safe to iterate

aduh95
authored and
targos
committed
lib: make safe primordials safe to construct

aduh95
authored and
targos
committed
lib: add primordials.SafeStringIterator

aduh95
authored and
targos
committed
buffer: make FastBuffer safe to construct

aduh95
authored and
targos
committed
url: refactor to use more primordials

aduh95
authored and
targos
committed
lib: refactor to use primordials in internal/priority_queue.js

Lxxyx
authored and
targos
committed
tools: update gyp-next to v0.7.0
targos
committed
lib: refactor to use more primordials in internal/encoding.js

RaisinTen
authored and
targos
committed
https: refactor to use more primordials

aduh95
authored and
targos
committed
lib: remove unused code

mscdex
authored and
targos
committed
stream: only use legacy close listeners if not willEmitClose

ronag
authored and
targos
committed
test: add test for reused AbortController with execfile()

Trott
authored and
targos
committed
child_process: treat already-aborted controller as aborting

Trott
authored and
targos
committed
child_process: reduce abort handler code duplication

Trott
authored and
targos
committed
test: add already-aborted-controller test for spawn()

Trott
authored and
targos
committed
string_decoder: throw ERR_STRING_TOO_LONG for UTF-8
targos
committed
errors: refactor to use more primordials

aduh95
authored and
targos
committed
lib: remove v8_prof_polyfill from eslint ignore list

aduh95
authored and
targos
committed
perf_hooks: refactor to avoid unsafe array iteration

aduh95
authored and
targos
committed
test: guard large string decoder allocation
targos
committed
wasi: refactor to avoid unsafe array iteration

aduh95
authored and
targos
committed
tty: refactor to avoid unsafe array iteration

aduh95
authored and
targos
committed
zlib: refactor to use primordial instead of <string>.startsWith

rchougule
authored and
targos
committed
events: refactor to use optional chaining

Lxxyx
authored and
targos
committed
doc: clarify event.isTrusted text

Trott
authored and
targos
committed
lib: simplify `primordials.uncurryThis`

ExE-Boss
authored and
targos
committed
vm: refactor to avoid unsafe array iteration

aduh95
authored and
targos
committed
lib: refactor source_map to avoid unsafe array iteration

aduh95
authored and
targos
committed
zlib: refactor to avoid unsafe array iteration

aduh95
authored and
targos
committed
lib: refactor source_map to use more primordials

aduh95
authored and
targos
committed
lib: expose primordials object

aduh95
authored and
targos
committed
test: improve coverage at `lib/internal/vm/module.js`

juanarbol
authored and
targos
committed
test: improve coverage on worker threads

juanarbol
authored and
targos
committed
test: improve coverage for `Module` getters

juanarbol
authored and
targos
committed
tools: update ESLint to 7.18.0

cjihrig
authored and
targos
committed
module: simplify tryStatSync with throwIfNoEntry option

aduh95
authored and
targos
committed
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param is NaN

Lxxyx
authored and
targos
committed
lib: support returning Safe collections from C++

ExE-Boss
authored and
targos
committed
test: improve coverage of `SourceTextModule` getters

juanarbol
authored and
targos
committed
lib: refactor to use optional chaining in internal/options.js

RaisinTen
authored and
targos
committed
test: increase timeout on ASAN Action

aduh95
authored and
targos
committed
async_hooks: refactor to avoid unsafe array iteration

aduh95
authored and
targos
committed
tools: update ESLint to 7.19.0

cjihrig
authored and
targos
committed
tools: update ESLint to 7.20.0

cjihrig
authored and
targos
committed
tools: update ESLint to 7.21.0

lpinca
authored and
targos
committed
test: increase fs promise coverage

emilsivervik
authored and
targos
committed
timers: fix unsafe array iteration

RaisinTen
authored and
targos
committed
lib: fix WebIDL `object` and dictionary type conversion

ExE-Boss
authored and
targos
committed
errors: align source-map stacks with spec

bcoe
authored and
targos
committed
worker: refactor to avoid unsafe array iteration

aduh95
authored and
targos
committed
tools: refactor prefer-primordials

aduh95
authored and
targos
committed
lib: add URI handling functions to primordials

aduh95
authored and
targos
committed
src: avoid implicit type conversions (take 2)
targos
committed
src: disable unfixable MSVC warnings
targos
committed
src: fix ETW_WRITE_EMPTY_EVENT macro
targos
committed
assert: refactor to avoid unsafe array iteration

aduh95
authored and
targos
committed
tools: run doctool tests on GitHub Actions CI

aduh95
authored and
targos
committed
doc: document the NO_COLOR and FORCE_COLOR env vars

jasnell
authored and
targos
committed
doc: document how to register external bindings for snapshot

joyeecheung
authored and
targos
committed
doc: remove generated from dsaEncoding description

kaznovac
authored and
targos
committed
doc: add document for http.OutgoingMessage

Ayase-252
authored and
targos
committed
doc: fix grammar errors in http document

Ayase-252
authored and
targos
committed
module: refactor NativeModule to avoid unsafe array iteration

aduh95
authored and
targos
committed
tools: simplify eslint comma-dangle configuration

Trott
authored and
targos
committed
doc: fix wording in outgoingMessage.write

tniessen
authored and
targos
committed
tools: simplify eslint comma-dangle configuration (tools)

Trott
authored and
targos
committed
src: indent long help text properly

glasser
authored and
targos
committed
path: refactor to use more primordials

marsonya
authored and
targos
committed
doc: add missing events.on metadata

addaleax
authored and
targos
committed
doc: internal/test/binding for testing

bmeck
authored and
targos
committed
tls: fix session and keylog add listener segfault

Linkgoron
authored and
targos
committed
module: clarify CJS global-like variables not defined error message

aduh95
authored and
targos
committed
node-api: make reference weak parameter an indirect link to references

legendecas
authored and
targos
committed
tools: fix type mismatch in test runner

richardlau
authored and
targos
committed
test: use .test domain for not found address

richardlau
authored and
targos
committed
doc: use `foo.prototype.bar` notation in buffer.md

VoltrexKeyva
authored and
targos
committed
test: replace function with arrow function and remove unused argument

andresatencio
authored and
targos
committed
repl: display prompt once after error callback

addaleax
authored and
targos
committed
doc: update TSC members list with three new members

Trott
authored and
targos
committed
doc: add nodejs-sec email template

danbev
authored and
targos
committed
tls: validate ticket keys buffer

aduh95
authored and
targos
committed
doc: fix typo in buffer.md

theoludwig
authored and
targos
committed
test: add ancestor package.json checks for tmpdir

richardlau
authored and
targos
committed
src: avoid deferred gc/cleanup for Buffer.from

jasnell
authored and
targos
committed
src: fix setting Converter sub char length

jasnell
authored and
targos
committed
typings: add JSDoc typings for util

rohit-gohri
authored and
targos
committed
doc: fix `package.json` `"imports"` field history

aduh95
authored and
targos
committed
doc: fix version history for `"exports"` patterns

aduh95
authored and
targos
committed
benchmark: use `process.hrtime.bigint()`

aduh95
authored and
targos
committed
doc: mark `process.hrtime()` as legacy

aduh95
authored and
targos
committed
async_hooks,doc: replace process.stdout.fd with 1

RaisinTen
authored and
targos
committed
lib: fix and improve os typings

marsonya
authored and
targos
committed
test: skip some pummel tests on slower machines

Trott
authored and
targos
committed
doc: request default snap track be updated for LTS

rvagg
authored and
targos
committed
src: use %progbits instead of @progbits

sgallagher
authored and
targos
committed
benchmark: avoid using `console.log()`

aduh95
authored and
targos
committed
test: move abort test from pummel to abort directory

Trott
authored and
targos
committed
doc: update message to match actual output

Trott
authored and
targos
committed
doc: do not mention TCP in the allowHalfOpen option description

lpinca
authored and
targos
committed
doc: document new TCP_KEEPCNT and TCP_KEEPINTVL socket option defaults

ArnoldZokas
authored and
targos
committed
doc: minor clarification to pathObject

jasnell
authored and
targos
committed
doc: note the system requirements for V8 tests

DeeDeeG
authored and
targos
committed
tools: add _depot_tools to PATH (for V8 tests)

DeeDeeG
authored and
targos
committed
tools: fix doc generation when version info is not available

aduh95
authored and
targos
committed
repl: document top level await limitation with const/let

jasnell
authored and
targos
committed
tools: remove fixer for non-ascii-character ESLint custom rule

Trott
authored and
targos
committed
src: fix validation of negative offset to avoid abort

jasnell
authored and
targos
committed
doc: add try/catch in http2 respondWithFile example

mcollina
authored and
targos
committed
doc: indicate that abort tests do not generate core files

Trott
authored and
targos
committed
doc: add arguments for stream event of Http2Server and Http2SecureServer

Ayase-252
authored and
targos
committed
doc: mark querystring api as legacy

jasnell
authored and
targos
committed
deps: update to [email protected]

guybedford
authored and
targos
committed
meta: post comment when pr labeled fast-track

jasnell
authored and
targos
committed
inspector: remove redundant method for connection check

yashLadha
authored and
targos
committed
test: address deprecation warning

Trott
authored and
targos
committed
zlib: fix brotli flush range

XadillaX
authored and
targos
committed
tools: use a shallow clone of the npm/cli repository

lpinca
authored and
targos
committed
doc: document `'secureConnect'` event limitation

jasnell
authored and
targos
committed
test: fix `common.mustCall` `length` and `name` properties

aduh95
authored and
targos
committed
test,readline: improve tab completion coverage

aduh95
authored and
targos
committed
stream: the position of _read() is wrong

helloyou2012
authored and
targos
committed
tools: use mktemp to create the workspace directory

lpinca
authored and
targos
committed
test: move test-net-connect-econnrefused from pummel to sequential

Trott
authored and
targos
committed
doc: remove extraneous dash from flag prefix

rhcarvalho
authored and
targos
committed
tools: make GH Actions workflows work if default branch is not master

aduh95
authored and
targos
committed
test: run message and pseudo-tty tests in parallel

richardlau
authored and
targos
committed
doc: use AIX instead of Aix in fs.md

Trott
authored and
targos
committed
doc: clarify DiffieHellmanGroup class docs

Linkgoron
authored and
targos
committed
test: increase coverage for AbortController

Lxxyx
authored and
targos
committed
test: complete coverage of querystring

pd4d10
authored and
targos
committed
lib: make `IterableWeakMap` safe to iterate

aduh95
authored and
targos
committed
Revert "worker: remove `ERR_CLOSED_MESSAGE_PORT`"

juanarbol
authored and
targos
committed
src: make workers messaging more resilient

juanarbol
authored and
targos
committed
buffer: remove unreachable code

pd4d10
authored and
targos
committed
test: call functions internally

VoltrexKeyva
authored and
targos
committed
meta: add v8 team

gengjiawen
authored and
targos
committed
buffer: remove TODOs in `atob` / `btoa`

XadillaX
authored and
targos
committed
dgram: extract cluster lazy loading method to make it testable

pd4d10
authored and
targos
committed
build: remove dependency on `distutils.spawn`

richardlau
authored and
targos
committed
build: add workaround for V8 builds

richardlau
authored and
targos
committed
fs: fix error when writing buffers > INT32_MAX

zbjornson
authored and
targos
committed
path: inline conditions

VoltrexKeyva
authored and
targos
committed
test: improve coverage of lib/os.js

pd4d10
authored and
targos
committed
test: improve coverage of lib/_http_client.js

pd4d10
authored and
targos
committed
doc: change color of doctag on night mode

Ayase-252
authored and
targos
committed
doc: update contact info

gabrielschulhof
authored and
targos
committed
src: remove extra semi after member fn

codebytere
authored and
targos
committed
src: update cares_wrap OpenBSD defines

addaleax
authored and
targos
committed
doc: clarify synchronous blocking of Worker stdio

jasnell
authored and
targos
committed
doc: document buffer.kStringMaxLength

tniessen
authored and
targos
committed
node-api: fix shutdown crashes

mhdawson
authored and
targos
committed
stream: fix multiple Writable.destroy() calls

ronag
authored and
targos
committed
node-api: faster threadsafe_function

indutny
authored and
targos
committed
doc: remove import.meta.resolve parent URL type

kevinoid
authored and
targos
committed
test,doc,lib: adjust object literal newlines for lint rule

Trott
authored and
targos
committed
tools: enable object-curly-newline in ESLint rules

Trott
authored and
targos
committed
tools: update eslint-plugin-markdown configuration

cjihrig
authored and
targos
committed
tools: add support for mjs and cjs JS snippet linting

aduh95
authored and
targos
committed
tools,doc: add support for several flavors of JS code snippets

aduh95
authored and
targos
committed
doc: use `HEAD` instead of `master` for links

aduh95
authored and
targos
committed
tools: make update-eslint.sh work with npm@7

lpinca
authored and
targos
committed
tools: update ESLint to 7.22.0

cjihrig
authored and
targos
committed
tools: update ESLint to 7.23.0

lpinca
authored and
targos
committed
tools: update ESLint to 7.24.0

cjihrig
authored and
targos
committed
tools: update ESLint to 7.25.0

cjihrig
authored and
targos
committed
tools: update ESLint to 7.26.0

cjihrig
authored and
targos
committed
tools: update ESLint to 7.27.0

lpinca
authored and
targos
committed
doc: fix JS flavor selection

aduh95
authored and
targos
committed
doc: cleanup events.md structure

jasnell
authored and
targos
committed
assert: refactor to use more primordials

aduh95
authored and
targos
committed
tools: bump cpplint.py to 1.5.2

Trott
authored and
targos
committed
tools: refloat 7 Node.js patches to cpplint.py

Trott
authored and
targos
committed
tools: bump cpplint to 1.5.3

Trott
authored and
targos
committed
tools: refloat 7 Node.js patches to cpplint.py

Trott
authored and
targos
committed
tools: bump cpplint to 1.5.4

Trott
authored and
targos
committed
tools: refloat 7 Node.js patches to cpplint.py

Trott
authored and
targos
committed
build: work around bug in MSBuild v16.10.0
targos
committed

Commits on Jun 6, 2021

http2: fix setting options before handle exists

addaleax
authored and
targos
committed
http2: treat non-EOF empty frames like other invalid frames

addaleax
authored and
targos
committed
src: add maybe versions of EmitExit and EmitBeforeExit

addaleax
authored and
targos
committed

Commits on Jun 8, 2021

Commits on Jun 9, 2021

fixup! lib: revert primordials in a hot path
aduh95
committed