fs: use createDeferredPromise() in promises.watch() #37386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
fs
targos
approved these changes
Feb 15, 2021
benjamingr
approved these changes
Feb 15, 2021
lpinca
approved these changes
Feb 15, 2021
jasnell
approved these changes
Feb 15, 2021
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
Oh nice, I hadn't seen that the utility had already landed.
Collaborator
Collaborator
Collaborator
RaisinTen
approved these changes
Feb 17, 2021
Member
|
I think this should be rebased to include 1c6484b for a green CI. |
Collaborator
Collaborator
cjihrig
added
the
author ready
This commit updates fsPromises.watch() to use the createDeferredPromise() utility. PR-URL: nodejs#37386 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Feb 28, 2021
This commit updates fsPromises.watch() to use the createDeferredPromise() utility. PR-URL: #37386 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates
fsPromises.watch()to use thecreateDeferredPromise()utility.