Exit after printing v8 help #34135
Closed
Exit after printing v8 help #34135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V8 es not exit the process after handling --help anymore: https://chromium-review.googlesource.com/c/v8/v8/+/2276276
nodejs-github-bot
added
the
c++
Contributor
Author
|
Looks like I need to land this first to https://github.com/v8/node/ and then it will be upstreamed. Closing the PR. |
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Jun 30, 2020
V8 will not exit the process after handling --help anymore: https://chromium-review.googlesource.com/c/v8/v8/+/2276276 As a drive-by fix, correctly return in the `print_bash_completion` case as well. Refs: nodejs#34135 Co-authored-by: Ulan Degenbaev <[email protected]>
2 tasks
Member
|
@ulan I can’t reopen this, but opening a PR here is the right thing to do. (I’m not sure how quickly v8/node picks that up, though, so making a PR there might be more convenient.) This needs to be modified in at least another place, and there’s a drive-by fix that sticks out to me for one of the locations, so I’ll just open a new PR here: #34136 |
Contributor
Author
|
I see, thanks for opening the new PR. I'll wait then until v8/node picks up the change. It is not urgent. |
addaleax
added a commit
that referenced
this pull request
Jul 7, 2020
V8 will not exit the process after handling --help anymore: https://chromium-review.googlesource.com/c/v8/v8/+/2276276 As a drive-by fix, correctly return in the `print_bash_completion` case as well. Refs: #34135 Co-authored-by: Ulan Degenbaev <[email protected]> PR-URL: #34136 Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2020
V8 will not exit the process after handling --help anymore: https://chromium-review.googlesource.com/c/v8/v8/+/2276276 As a drive-by fix, correctly return in the `print_bash_completion` case as well. Refs: #34135 Co-authored-by: Ulan Degenbaev <[email protected]> PR-URL: #34136 Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 16, 2020
V8 will not exit the process after handling --help anymore: https://chromium-review.googlesource.com/c/v8/v8/+/2276276 As a drive-by fix, correctly return in the `print_bash_completion` case as well. Refs: #34135 Co-authored-by: Ulan Degenbaev <[email protected]> PR-URL: #34136 Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8 does not exit the process after handling --help anymore:
https://chromium-review.googlesource.com/c/v8/v8/+/2276276
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes