Skip to content

contextify: use assert instead of if #3125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
obastemur wants to merge 2 commits into from
Closed

contextify: use assert instead of if #3125

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0581b0
contextify: use assert instead of `if`
obastemur Sep 30, 2015
f9ba0dc
use CHECK instead of assert
obastemur Sep 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/node_contextify.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,9 @@ class ContextifyContext {
object_template->SetHandler(config);

Local<Context> ctx = Context::New(env->isolate(), nullptr, object_template);
if (!ctx.IsEmpty())
ctx->SetSecurityToken(env->context()->GetSecurityToken());

assert(!ctx.IsEmpty());
Copy link
Member

@bnoordhuis bnoordhuis Sep 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use CHECK(...) here?

ctx->SetSecurityToken(env->context()->GetSecurityToken());

env->AssignToContext(ctx);

Expand Down