Revert "dgram: implicit binds should be exclusive" #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Contributor
|
LGTM. Might be worth fixing instead of just reverting if it is a quick fix. |
Member
|
Is this going to land us with a minor/subtle incompatibility with joyent/node? |
Contributor
|
Yes, but the same PR is open on joyent/node and should be in 0.12. |
Member
|
In that case LGTM |
Contributor
|
Let me clarify - the original PR to add this feature is open on joyent/node. The revert is only on io.js, but I assume the revert would be needed there as well. |
This reverts commit a32b92d. Reverted for breaking the parallel/test-cluster-dgram-2 test on all platforms. PR-URL: nodejs#279 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
bnoordhuis
force-pushed
the
revert-a32b92d
branch
from
9bd4111 to
0526d83
Compare
Member
Author
|
I didn't spent too much time investigating why the test fails, that's for Sam and Bert to figure out. I just ran |
Contributor
|
I'll figure out and fix. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a32b92d.
Reverted for breaking the parallel/test-cluster-dgram-2 test on all
platforms.
R=@piscisaureus @sam-github