test: remove check for valid hostname in test-dns.js #2785
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Member
|
LGTM |
Member
Author
|
Two CI failures appear unrelated. Meanwhile, here's a CI that I've kinda sorta tricked into running the The FreeBSD failures are unrelated. (That's a different test that needs to be sorted.) This fixes the test on |
Operating systems can and do return invalid hostnames if that's what they have (for example) in /etc/hosts. Test passes if no error is thrown and the hostname string is not empty. Fixes: nodejs#2468
Trott
force-pushed
the
test-dns-hostname-check
branch
from
c190178 to
cd12f23
Compare
Trott
added a commit
that referenced
this pull request
Sep 10, 2015
Operating systems can and do return invalid hostnames if that's what they have (for example) in /etc/hosts. Test passes if no error is thrown and the hostname string is not empty. Fixes: #2468 PR-URL: #2785 Reviewed-By: Ben Noordhuis <[email protected]>
Member
Author
|
Landed in a1949e8 |
Trott
added a commit
that referenced
this pull request
Sep 11, 2015
Operating systems can and do return invalid hostnames if that's what they have (for example) in /etc/hosts. Test passes if no error is thrown and the hostname string is not empty. Fixes: #2468 PR-URL: #2785 Reviewed-By: Ben Noordhuis <[email protected]>
Trott
added a commit
that referenced
this pull request
Sep 12, 2015
Operating systems can and do return invalid hostnames if that's what they have (for example) in /etc/hosts. Test passes if no error is thrown and the hostname string is not empty. Fixes: #2468 PR-URL: #2785 Reviewed-By: Ben Noordhuis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operating systems can and do return invalid hostnames if that's
what they have (for example) in /etc/hosts. Test passes if no
error is thrown and the hostname string is not empty.
Fixes: #2468