Skip to content

buffer,error: improve bigint, big numbers and more #27228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 6 commits into from
Closed

buffer,error: improve bigint, big numbers and more #27228

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8dd4ba0
buffer,error: improve bigint, big numbers and more
BridgeAR Apr 14, 2019
1987eeb
fixup! buffer,error: improve bigint, big numbers and more
BridgeAR Apr 15, 2019
9e05154
fixup! buffer,error: improve bigint, big numbers and more
BridgeAR Apr 23, 2019
f823287
fixup! buffer,error: improve bigint, big numbers and more
BridgeAR Apr 25, 2019
19aebdc
fixup! buffer,error: improve bigint, big numbers and more
BridgeAR Apr 26, 2019
f7c61bb
fixup! buffer,error: improve bigint, big numbers and more
BridgeAR Apr 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions lib/internal/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,6 +574,22 @@ function oneOf(expected, thing) {
}
}

function addNumericalSeparator(val) {
let res = val[val.length - 1];
let count = 0;
for (let i = val.length - 2; i >= 0; i--) {
count++;
if (val[i] === '.') {
return val;
}
if (count % 3 === 0 && i !== val.length && val[i] !== '-') {
res = `_${res}`;
}
res = `${val[i]}${res}`;
}
return res;
}

module.exports = {
addCodeToName, // Exported for NghttpError
codes,
Expand Down Expand Up @@ -1001,12 +1017,12 @@ E('ERR_OUT_OF_RANGE',
`The value of "${str}" is out of range.`;
let received;
if (Number.isInteger(input) && Math.abs(input) > 2 ** 32) {
received = String(input).replace(/(\d)(?=(\d\d\d)+(?!\d))/g, '$1_');
received = addNumericalSeparator(String(input));
// eslint-disable-next-line valid-typeof
} else if (typeof input === 'bigint') {
received = String(input);
if (input > 2n ** 32n || input < -(2n ** 32n)) {
received = received.replace(/(\d)(?=(\d\d\d)+(?!\d))/g, '$1_');
received = addNumericalSeparator(received);
}
received += 'n';
} else {
Expand Down